Skip to content

Commit 8e50b03

Browse files
authored
Merge pull request #59 from FullstackAcademy/testingEdits
Testing edits Closes #55
2 parents 5548efb + c42b949 commit 8e50b03

File tree

8 files changed

+37
-11
lines changed

8 files changed

+37
-11
lines changed

generated/gulpfile.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,16 @@ gulp.task('buildJS', ['lintJS'], function () {
5555

5656
gulp.task('testServerJS', function () {
5757
require('babel-register');
58+
//testing environment variable
59+
process.env.NODE_ENV = 'testing';
5860
return gulp.src('./tests/server/**/*.js', {
5961
read: false
6062
}).pipe(mocha({ reporter: 'spec' }));
6163
});
6264

6365
gulp.task('testServerJSWithCoverage', function (done) {
66+
//testing environment variable
67+
process.env.NODE_ENV = 'testing';
6468
gulp.src('./server/**/*.js')
6569
.pipe(istanbul({
6670
includeUntested: true
@@ -78,6 +82,8 @@ gulp.task('testServerJSWithCoverage', function (done) {
7882
});
7983

8084
gulp.task('testBrowserJS', function (done) {
85+
//testing environment variable
86+
process.env.NODE_ENV = 'testing';
8187
karma.start({
8288
configFile: __dirname + '/tests/browser/karma.conf.js',
8389
singleRun: true

generated/server/db/_db.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ var path = require('path');
22
var Sequelize = require('sequelize');
33

44
var env = require(path.join(__dirname, '../env'));
5-
var db = new Sequelize(env.DATABASE_URI);
5+
var db = new Sequelize(env.DATABASE_URI, { logging: env.LOGGING });
66

77
module.exports = db;

generated/server/env/development.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,6 @@ module.exports = {
1515
"clientID": "INSERT_GOOGLE_CLIENTID_HERE",
1616
"clientSecret": "INSERT_GOOGLE_CLIENT_SECRET_HERE",
1717
"callbackURL": "INSERT_GOOGLE_CALLBACK_HERE"
18-
}
18+
},
19+
"LOGGING": true
1920
};

generated/server/env/index.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
var path = require('path');
22
var devConfigPath = path.join(__dirname, './development.js');
33
var productionConfigPath = path.join(__dirname, './production.js');
4+
var testConfigPath = path.join(__dirname, './testing.js');
45

56
if (process.env.NODE_ENV === 'production') {
67
module.exports = require(productionConfigPath);
8+
} else if (process.env.NODE_ENV === 'testing') {
9+
module.exports = require(testConfigPath);
710
} else {
811
module.exports = require(devConfigPath);
912
}

generated/server/env/production.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@ module.exports = {
2323
"clientID": process.env.GOOGLE_CLIENT_ID,
2424
"clientSecret": process.env.GOOGLE_CLIENT_SECRET,
2525
"callbackURL": process.env.GOOGLE_CALLBACK_URL
26-
}
26+
},
27+
"LOGGING": true
2728
};

generated/server/env/testing.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
module.exports = {
2+
"DATABASE_URI": "postgres://localhost:5432/testing-fsg",
3+
"SESSION_SECRET": "Optimus Prime is my real dad",
4+
"TWITTER": {
5+
"consumerKey": "INSERT_TWITTER_CONSUMER_KEY_HERE",
6+
"consumerSecret": "INSERT_TWITTER_CONSUMER_SECRET_HERE",
7+
"callbackUrl": "INSERT_TWITTER_CALLBACK_HERE"
8+
},
9+
"FACEBOOK": {
10+
"clientID": "INSERT_FACEBOOK_CLIENTID_HERE",
11+
"clientSecret": "INSERT_FACEBOOK_CLIENT_SECRET_HERE",
12+
"callbackURL": "INSERT_FACEBOOK_CALLBACK_HERE"
13+
},
14+
"GOOGLE": {
15+
"clientID": "INSERT_GOOGLE_CLIENTID_HERE",
16+
"clientSecret": "INSERT_GOOGLE_CLIENT_SECRET_HERE",
17+
"callbackURL": "INSERT_GOOGLE_CALLBACK_HERE"
18+
},
19+
"LOGGING": false
20+
};

generated/tests/server/models/user-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@ var sinon = require('sinon');
22
var expect = require('chai').expect;
33

44
var Sequelize = require('sequelize');
5-
var dbURI = 'postgres://localhost:5432/testing-fsg';
6-
var db = new Sequelize(dbURI);
75

8-
require('../../../server/db/models/user')(db);
6+
var db = require('../../../server/db');
97

108
var User = db.model('user');
119

generated/tests/server/routes/members-only-test.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,8 @@
22
var expect = require('chai').expect;
33

44
var Sequelize = require('sequelize');
5-
var dbURI = 'postgres://localhost:5432/testing-fsg';
6-
var db = new Sequelize(dbURI, {
7-
logging: false
8-
});
9-
require('../../../server/db/models/user')(db);
5+
6+
var db = require('../../../server/db');
107

118
var supertest = require('supertest');
129

0 commit comments

Comments
 (0)