Skip to content

Commit d574821

Browse files
authored
Merge pull request #80 from FullstackAcademy/database-environment-url-fix
Database environment url fix
2 parents bcf1065 + 26430cc commit d574821

File tree

7 files changed

+20
-20
lines changed

7 files changed

+20
-20
lines changed

generated/gulpfile.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ var ngAnnotate = require('gulp-ng-annotate');
1212
var uglify = require('gulp-uglify');
1313
var sourcemaps = require('gulp-sourcemaps');
1414
var eslint = require('gulp-eslint');
15+
var karma = require('karma');
1516
var mocha = require('gulp-spawn-mocha');
16-
var karma = require('karma').server;
1717
var istanbul = require('gulp-istanbul');
1818
var notify = require('gulp-notify');
1919

@@ -84,10 +84,11 @@ gulp.task('testServerJSWithCoverage', function (done) {
8484
gulp.task('testBrowserJS', function (done) {
8585
//testing environment variable
8686
process.env.NODE_ENV = 'testing';
87-
karma.start({
87+
var server = new karma.Server({
8888
configFile: __dirname + '/tests/browser/karma.conf.js',
8989
singleRun: true
9090
}, done);
91+
server.start();
9192
});
9293

9394
gulp.task('buildCSS', function () {

generated/server/app/configure/index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ module.exports = function (app, db) {
1616

1717
// Logging middleware, set as application
1818
// variable inside of server/app/configure/app-variables.js
19-
app.use(app.getValue('log'));
19+
if (process.env.NODE_ENV !== 'testing') {
20+
app.use(app.getValue('log'));
21+
}
2022

2123
require('./authentication')(app, db);
2224

generated/server/db/_db.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ var path = require('path');
22
var Sequelize = require('sequelize');
33

44
var env = require(path.join(__dirname, '../env'));
5-
var db = new Sequelize(env.DATABASE_URI, {
6-
logging: env.LOGGING,
5+
var db = new Sequelize(env.DATABASE_URL, {
6+
logging: env.LOGGING ? console.log : false,
77
native: env.NATIVE
88
});
99

generated/server/db/models/user.js

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,14 @@ module.exports = db.define('user', {
4545
}
4646
},
4747
hooks: {
48-
beforeCreate: function (user) {
49-
if (user.changed('password')) {
50-
user.salt = user.Model.generateSalt();
51-
user.password = user.Model.encryptPassword(user.password, user.salt);
52-
}
53-
},
54-
beforeUpdate: function (user) {
55-
if (user.changed('password')) {
56-
user.salt = user.Model.generateSalt();
57-
user.password = user.Model.encryptPassword(user.password, user.salt);
58-
}
59-
}
48+
beforeCreate: setSaltAndPassword,
49+
beforeUpdate: setSaltAndPassword
6050
}
6151
});
52+
53+
function setSaltAndPassword(user) {
54+
if (user.changed('password')) {
55+
user.salt = user.Model.generateSalt();
56+
user.password = user.Model.encryptPassword(user.password, user.salt);
57+
}
58+
}

generated/server/env/development.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
2-
DATABASE_URI: 'postgres://localhost:5432/fsg',
2+
DATABASE_URL: 'postgres://localhost:5432/fsg',
33
SESSION_SECRET: 'Optimus Prime is my real dad',
44
TWITTER: {
55
consumerKey: 'INSERT_TWITTER_CONSUMER_KEY_HERE',

generated/server/env/production.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
module.exports = {
10-
DATABASE_URI: process.env.DATABASE_URI,
10+
DATABASE_URL: process.env.DATABASE_URL,
1111
SESSION_SECRET: process.env.SESSION_SECRET,
1212
TWITTER: {
1313
consumerKey: process.env.TWITTER_CONSUMER_KEY,

generated/server/env/testing.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
2-
DATABASE_URI: 'postgres://localhost:5432/testing-fsg',
2+
DATABASE_URL: 'postgres://localhost:5432/testing-fsg',
33
SESSION_SECRET: 'Optimus Prime is my real dad',
44
TWITTER: {
55
consumerKey: 'INSERT_TWITTER_CONSUMER_KEY_HERE',

0 commit comments

Comments
 (0)