add missing pclose()

Signed-off-by: Vincent-FK <[email protected]>

Author: Vincent-FK

menu/main.cpp

@@ -410,7 +410,9 @@ uint32 S9xReadJoypad (int which1)
         fp = popen(shell_cmd, "r");
         if (fp == NULL) {
 		printf("Failed to run command %s\n", shell_cmd);
-		}
+	} else {
+		pclose(fp);
+	}
 
         // Save config file
         configfile_save(cfg_file_rom);
@@ -599,16 +601,21 @@ void S9xLoadSRAM (void)
 /* Quick save and turn off the console */
 void quick_save_and_poweroff()
 {
+	FILE * fp;
+
 	printf("Save Instant Play file\n");
 
 	/* Send command to cancel any previously scheduled powerdown */
-	if (popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r") == NULL)
+	fp = popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r");
+	if (fp == NULL)
 	{
 		/* Countdown is still ticking, so better do nothing
 		   than start writing and get interrupted!
 		*/
 		printf("Failed to cancel scheduled shutdown\n");
 		exit(0);
+	} else {
+		pclose(fp);
 	}
 
 	/* Save  */

menu/menu.cpp

@@ -397,6 +397,7 @@ void init_menu_system_values(){
         volume_percentage = 50; ///wrong value: setting default to 50
     }
     else{
+        pclose(fp);
         fgets(res, sizeof(res)-1, fp);
 
         /// Check if Volume is a number (at least the first char)
@@ -417,6 +418,7 @@ void init_menu_system_values(){
         brightness_percentage = 50; ///wrong value: setting default to 50
     }
     else{
+        pclose(fp);
         fgets(res, sizeof(res)-1, fp);
 
         /// Check if brightness is a number (at least the first char)
@@ -659,7 +661,10 @@ void run_menu_loop()
 			RES_HW_SCREEN_HORIZONTAL * RES_HW_SCREEN_VERTICAL * sizeof(u16));
 
     /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     /// -------- Main loop ---------
     while (!stop_menu_loop)
@@ -737,7 +742,9 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
-                            }
+                            } else {
+			        pclose(fp);
+			    }
 
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -753,6 +760,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                         /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -809,6 +818,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -824,6 +835,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -885,6 +898,8 @@ void run_menu_loop()
                                 fp = popen(shell_cmd, "r");
                                 if (fp == NULL) {
                                     MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+				} else {
+				    pclose(fp);
                                 }
 
                                 stop_menu_loop = 1;
@@ -922,6 +937,8 @@ void run_menu_loop()
                                 fp = popen(shell_cmd, "r");
                                 if (fp == NULL) {
                                     MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+				} else {
+			            pclose(fp);
                                 }
 
                                 stop_menu_loop = 1;
@@ -1019,7 +1036,10 @@ void run_menu_loop()
     }
 
     /* Start Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 }
 
 
@@ -1042,9 +1062,13 @@ int launch_resume_menu_loop()
     uint8_t screen_refresh = 1;
     uint8_t menu_confirmation = 0;
     int option_idx=RESUME_YES;
+    FILE *fp;
 
     /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     /* Save prev key repeat params and set new Key repeat */
     SDL_GetKeyRepeat(&backup_key_repeat_delay, &backup_key_repeat_interval);
@@ -1209,7 +1233,10 @@ int launch_resume_menu_loop()
     }
 
     /* Start Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     return option_idx;
 }