add missing pclose()

Signed-off-by: Vincent-FK <[email protected]>

Author: Vincent-FK

src/drivers/dingux-sdl/dingoo.cpp

@@ -298,17 +298,20 @@ void handle_sigusr1(int sig)
 /* Quick save and turn off the console */
 void quick_save_and_poweroff()
 {
+	FILE *fp;
 	printf("Save Instant Play file\n");
 
 	/* Send command to cancel any previously scheduled powerdown */
-	if (popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r") == NULL)
+	fp = popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r");
+	if (fp == NULL)
 	{
 	        /* Countdown is still ticking, so better do nothing
 	           than start writing and get interrupted!
 		*/
 		printf("Failed to cancel scheduled shutdown\n");
 		exit(0);
 	}
+	pclose(fp);
 
 	/* Save  */
 	FCEUI_SaveState(quick_save_file);

src/drivers/dingux-sdl/input.cpp

@@ -332,6 +332,8 @@ static void KeyboardCommands() {
 		fp_tmp = popen(shell_cmd_tmp, "r");
 		if (fp_tmp == NULL) {
 			printf("Failed to run command %s\n", shell_cmd_tmp);
+		} else {
+		    pclose(fp_tmp);
 		}
 
       // Save config file

src/drivers/dingux-sdl/menu.cpp

@@ -377,6 +377,7 @@ void init_menu_system_values(){
         volume_percentage = 50; ///wrong value: setting default to 50
     }
     else{
+    	pclose(fp);
         fgets(res, sizeof(res)-1, fp);
 
         /// Check if Volume is a number (at least the first char)
@@ -397,6 +398,7 @@ void init_menu_system_values(){
         brightness_percentage = 50; ///wrong value: setting default to 50
     }
     else{
+    	pclose(fp);
         fgets(res, sizeof(res)-1, fp);
 
         /// Check if brightness is a number (at least the first char)
@@ -640,7 +642,10 @@ void run_menu_loop()
 			RES_HW_SCREEN_HORIZONTAL * RES_HW_SCREEN_VERTICAL * sizeof(u16));
 
     /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    if (fp != NULL) {
+    	pclose(fp);
+    }
 
     /// -------- Main loop ---------
     while (!stop_menu_loop)
@@ -718,7 +723,9 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
-                            }
+                            } else {
+			        pclose(fp);
+			    }
 
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -734,6 +741,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                         /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -790,6 +799,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -805,6 +816,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -865,6 +878,8 @@ void run_menu_loop()
                                 fp = popen(shell_cmd, "r");
                                 if (fp == NULL) {
                                     MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+				} else {
+			            pclose(fp);
                                 }
 
                                 stop_menu_loop = 1;
@@ -903,6 +918,8 @@ void run_menu_loop()
                                 fp = popen(shell_cmd, "r");
                                 if (fp == NULL) {
                                     MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+				} else {
+			            pclose(fp);
                                 }
 
                                 stop_menu_loop = 1;
@@ -998,7 +1015,10 @@ void run_menu_loop()
     }
 
     /* Start Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 }
 
 
@@ -1020,10 +1040,14 @@ int launch_resume_menu_loop()
     stop_menu_loop = 0;
     uint8_t screen_refresh = 1;
     uint8_t menu_confirmation = 0;
-    int option_idx=RESUME_YES; 
+    int option_idx=RESUME_YES;
+    FILE *fp;
 
     /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     /* Save prev key repeat params and set new Key repeat */
     SDL_GetKeyRepeat(&backup_key_repeat_delay, &backup_key_repeat_interval);
@@ -1188,7 +1212,10 @@ int launch_resume_menu_loop()
     }
 
     /* Start Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     return option_idx;
 }