add missing pclose()

Signed-off-by: Vincent-FK <[email protected]>

Author: Vincent-FK

src/drivers/input.cpp

@@ -860,8 +860,11 @@ void Input_Event(const SDL_Event *event)
     FILE *fp = popen(shell_cmd, "r");
     if (fp == NULL) {
       printf("Failed to run command %s\n", shell_cmd);
+    } else {
+      pclose(fp);
     }
 
+    
     // Save config file
     configfile_save(cfg_file_rom);
     break;
@@ -882,6 +885,8 @@ void Input_Event(const SDL_Event *event)
     FILE *fp = popen(shell_cmd, "r");
     if (fp == NULL) {
       printf("Failed to run command %s\n", shell_cmd);
+    } else {
+      pclose(fp);
     }
 
     // Save config file
@@ -905,6 +910,8 @@ void Input_Event(const SDL_Event *event)
     FILE *fp = popen(shell_cmd, "r");
     if (fp == NULL) {
       printf("Failed to run command %s\n", shell_cmd);
+    } else {
+      pclose(fp);
     }
 
     // Save config file

src/drivers/main.cpp

@@ -1282,17 +1282,21 @@ static volatile int gte_write = 0;
 /* Quick save and turn off the console */
 void quick_save_and_poweroff()
 {
+    FILE *fp;
+
     printf("Save Instant Play file\n");
 
     /* Send command to cancel any previously scheduled powerdown */
-    if (popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r") == NULL)
+    fp = popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r");
+    if (fp == NULL)
     {
         /* Countdown is still ticking, so better do nothing
 	   than start writing and get interrupted!
 	*/
         printf("Failed to cancel scheduled shutdown\n");
 	exit(0);
     }
+    pclose(fp);
 
     /* Quick Save  */
     MDFNI_SaveState(quick_save_file, NULL, NULL, NULL, NULL);

src/drivers/menu.cpp

@@ -431,6 +431,7 @@ void init_menu_system_values(){
         volume_percentage = 50; ///wrong value: setting default to 50
     }
     else{
+        pclose(fp);
         fgets(res, sizeof(res)-1, fp);
 
         /// Check if Volume is a number (at least the first char)
@@ -451,6 +452,7 @@ void init_menu_system_values(){
         brightness_percentage = 50; ///wrong value: setting default to 50
     }
     else{
+        pclose(fp);
         fgets(res, sizeof(res)-1, fp);
 
         /// Check if brightness is a number (at least the first char)
@@ -702,7 +704,10 @@ void run_menu_loop()
       RES_HW_SCREEN_HORIZONTAL * RES_HW_SCREEN_VERTICAL * sizeof(uint16_t));*/
 
     /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     /// -------- Main loop ---------
     while (!stop_menu_loop)
@@ -780,7 +785,9 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
-                            }
+                            } else {
+			        pclose(fp);
+			    } 
 
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -796,6 +803,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                         /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -856,6 +865,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -871,6 +882,8 @@ void run_menu_loop()
                             fp = popen(shell_cmd, "r");
                             if (fp == NULL) {
                                 MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+                            } else {
+			        pclose(fp);
                             }
                             /// ------ Refresh screen ------
                             screen_refresh = 1;
@@ -932,6 +945,8 @@ void run_menu_loop()
                                 fp = popen(shell_cmd, "r");
                                 if (fp == NULL) {
                                     MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+				} else {
+				    pclose(fp);
                                 }
 
                                 stop_menu_loop = 1;
@@ -969,6 +984,8 @@ void run_menu_loop()
                                 fp = popen(shell_cmd, "r");
                                 if (fp == NULL) {
                                     MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+				} else {
+				    pclose(fp);
                                 }
 
                                 stop_menu_loop = 1;
@@ -1069,7 +1086,10 @@ void run_menu_loop()
     }
 
     /* Start Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     /// ------ Reset last screen ------
     SDL_BlitSurface(backup_hw_screen, NULL, hw_screen, NULL);
@@ -1097,9 +1117,13 @@ int launch_resume_menu_loop()
     uint8_t menu_confirmation = 0;
     int option_idx=RESUME_YES;
     pumpWrap_disabled = 1;
+    FILE *fp;
 
     /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     /* Save prev key repeat params and set new Key repeat */
     SDL_GetKeyRepeat(&backup_key_repeat_delay, &backup_key_repeat_interval);
@@ -1273,7 +1297,10 @@ int launch_resume_menu_loop()
     pumpWrap_disabled = 0;
 
     /* Start Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+    if (fp != NULL) {
+        pclose(fp);
+    }
 
     return option_idx;
 }