Skip to content

Commit 5dbc280

Browse files
committed
Fix #12 and use sensible version numbers
1 parent fdc4a2a commit 5dbc280

File tree

4 files changed

+28
-4
lines changed

4 files changed

+28
-4
lines changed

Cirilla.Core.Test/Tests/GMDTests.cs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,12 @@ public void Load__cm_facility_kor()
6161
GMD gmd = new GMD(Utility.GetFullPath(@"chunk0/common/text/cm_facility_kor.gmd"));
6262
}
6363

64+
[TestMethod]
65+
public void Load__cm_status_eng()
66+
{
67+
GMD gmd = new GMD(Utility.GetFullPath(@"chunk0/common/text/cm_status_eng.gmd"));
68+
}
69+
6470
[TestMethod]
6571
public void Rebuild__em_names_eng()
6672
{
@@ -140,6 +146,19 @@ public void Rebuild__w_sword_eng()
140146
Assert.Fail("Hash doesn't match!");
141147
}
142148

149+
[TestMethod]
150+
public void Rebuild__cm_status_eng()
151+
{
152+
string origPath = Utility.GetFullPath(@"chunk0/common/text/cm_status_eng.gmd");
153+
string rebuildPath = "rebuild__cm_status_eng.gmd";
154+
155+
GMD gmd = new GMD(origPath);
156+
gmd.Save(rebuildPath);
157+
158+
if (!Utility.CheckFilesAreSame(origPath, rebuildPath))
159+
Assert.Fail("Hash doesn't match!");
160+
}
161+
143162
[TestMethod]
144163
public void AddString__q00503_eng()
145164
{

Cirilla.Core/Cirilla.Core.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
5-
<Version>0.0.5.1</Version>
5+
<Version>0.5.2.0</Version>
66
<Authors>Fusion86</Authors>
77
<Company />
88
</PropertyGroup>

Cirilla.Core/Models/GMD.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,15 @@ public GMD(string path) : base(path)
6565
Entries.Add(entry);
6666
}
6767

68+
// If there are "Invalid Message" entries after the last valid entry then the above code won't add GMD_EntryWithoutKey's for those entries
69+
// So here we add GMD_EntryWithoutKey entries till we have {StringCount} amount of them
70+
for (int i = Entries.Count; i < _header.StringCount; i++)
71+
Entries.Add(new GMD_EntryWithoutKey());
72+
6873
// Block with unknown data
6974
_unk1 = br.ReadBytes(0x800);
7075

71-
// Keys, his skips over the GMD_EntryWithoutKey entries
76+
// Keys, this skips over the GMD_EntryWithoutKey entries
7277
foreach (GMD_Entry entry in Entries.OfType<GMD_Entry>())
7378
{
7479
entry.Key = br.ReadStringZero(ExEncoding.ASCII);

Cirilla/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@
5151
// You can specify all the values or you can default the Build and Revision Numbers
5252
// by using the '*' as shown below:
5353
// [assembly: AssemblyVersion("1.0.*")]
54-
[assembly: AssemblyVersion("0.0.4.0")]
55-
[assembly: AssemblyFileVersion("0.0.4.0")]
54+
[assembly: AssemblyVersion("0.4.0.0")]
55+
[assembly: AssemblyFileVersion("0.4.0.0")]

0 commit comments

Comments
 (0)