Skip to content

Wrong regex in StringExtractor feature type #7

@laam-egg

Description

@laam-egg

In <project_root>/src/thrember/features.py, line 200 - 201:

"mac_addr": re.compile("\\b(?:[0-9A-Fa-f]{2}[:-]){5}(?:[0-9A-Fa-f]{2})\\b"),
"email_addr": re.compile("\\b(?:[0-9A-Fa-f]{2}[:-]){5}(?:[0-9A-Fa-f]{2})\\b"),

The regexes for MAC addresses and Email addresses are the same!

I guess this is worth knowing even though the model quality has been good so far.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions