Should Enum and Json fall back to default value upon read exception?

[wrozwad]

🇺🇸
After unsuccessful Enum/json read we should:
👍 quietly return default value
🎉 crash app being consistent with Fail-Fast rule
🚀 crash app only when BuildConfig.DEBUG == true

🇵🇱
Rozkmina dotyczy zachowania libki w przypadku migracji. Czy przy nieudanej próbie odczytania poprzednio zapisanej wartości, np. po zmianie Enuma/obiektu, powinniśmy:

👍 zwracać po cichu domyślną wartość
🎉 wywalać apkę wg zasady Fail-Fast
🚀 crashować apkę tylko przy BuildConfig.DEBUG == true

Aktualna implementacja zakłada 👍 opcję:

// Enum read
T::class.java.enumConstants.firstOrNull { it!!.name == enumName }

// Json read
try {
    jsonAdapter.fromJson(getString(key, null)!!)
} catch (e: Exception) {
    null
}

Niestety nie specjalnie mam koncepcję jak sensownie zaimplementować wersję 🚀 z BuildConfig.DEBUG == true 😕

[micHar]

I think we might drop polish lang, after all it's a public repo.

The original issue was that I was using a LocalDateTimeAdapter for Moshi which only read the value to LocalDateTime and did not write, so the value written to the prefs could not be parsed properly. In such case it would be much better if app crashed immediately, because the resulting error was very subtle.

On the other hand I can easily think of a scenario, where we would change the payload (e.g. new backend API version and incompatible payloads) and would rather have a default value returned from there instead of an exception.

That being said, I think that current solution is not explicit enough. I think we should consider an interface change that would make the intention around the migration and default values clear.

Not a fan of the BuildConfig, it also takes away the control from user.