Skip to content

Commit 30e3d59

Browse files
committed
Fix incompat with litematica
1 parent 283cc12 commit 30e3d59

File tree

5 files changed

+14
-17
lines changed

5 files changed

+14
-17
lines changed

common/src/main/java/ca/fxco/moreculling/api/blockstate/StateCullingShapeCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ public interface StateCullingShapeCache {
2525
*
2626
* @since 1.6.0
2727
*/
28-
void moreculling$initCustomCullingShape(BlockStateModel model);
28+
void moreculling$initCustomCullingShape();
2929

3030
}

common/src/main/java/ca/fxco/moreculling/mixin/models/cullshape/BlockStateBase_cullShapeMixin.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,17 @@ public abstract class BlockStateBase_cullShapeMixin implements StateCullingShape
3636

3737

3838
@Override
39-
public void moreculling$initCustomCullingShape(BlockStateModel model) {
39+
public void moreculling$initCustomCullingShape() {
4040
VoxelShape voxelShape = null;
41-
if (model != null) {
42-
if (((BakedOpacity) model).moreculling$getHasAutoModelShape() && this.canOcclude) {
43-
this.moreculling$cullingShapesByFace = occlusionShapesByFace;
44-
return;
41+
if (blockRenderManager != null) {
42+
BlockStateModel model = blockRenderManager.getBlockModel(this.asState());
43+
if (model != null) {
44+
if (((BakedOpacity) model).moreculling$getHasAutoModelShape() && this.canOcclude) {
45+
this.moreculling$cullingShapesByFace = occlusionShapesByFace;
46+
return;
47+
}
48+
voxelShape = ((BakedOpacity) model).moreculling$getCullingShape(this.asState());
4549
}
46-
voxelShape = ((BakedOpacity) model).moreculling$getCullingShape(this.asState());
4750
}
4851

4952
if (voxelShape == null) {
@@ -72,12 +75,7 @@ public abstract class BlockStateBase_cullShapeMixin implements StateCullingShape
7275
if (this.moreculling$cullingShapesByFace == null) {
7376
this.moreculling$cullingShapesByFace = EMPTY_OCCLUSION_SHAPES;
7477

75-
BlockStateModel model = null;
76-
if (blockRenderManager != null) {
77-
model = blockRenderManager.getBlockModel(asState());
78-
}
79-
80-
moreculling$initCustomCullingShape(model);
78+
moreculling$initCustomCullingShape();
8179

8280
}
8381
return this.moreculling$cullingShapesByFace[face.ordinal()];

common/src/main/java/ca/fxco/moreculling/utils/CacheUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ public static void resetAllCache() {
2525
return;
2626
}
2727
// Reset all model translucency cache
28+
Block.BLOCK_STATE_REGISTRY.forEach(state -> ((StateCullingShapeCache) state).moreculling$initCustomCullingShape());
2829
Map<BlockState, BlockStateModel> allModels = ((BlockModelShaperAccessor) blockRenderManager.getBlockModelShaper()).getModels();
2930
allModels.forEach((state, model) -> {
30-
((StateCullingShapeCache) state).moreculling$initCustomCullingShape(model);
3131
if (!state.canOcclude()) {
3232
((BakedOpacity) model).moreculling$resetTranslucencyCache(state);
3333
}

fabric/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ dependencies {
1111
modImplementation "net.fabricmc:fabric-loader:${fabric_loader_version}"
1212
modImplementation "net.fabricmc.fabric-api:fabric-api:${fabric_version}"
1313

14-
modCompileOnly "maven.modrinth:modmenu:${project.modmenu_version}"
15-
//modImplementation "maven.modrinth:sodium:${project.sodium_version}-fabric"
14+
modImplementation "maven.modrinth:modmenu:${project.modmenu_version}"
1615

1716
modImplementation "net.caffeinemc:sodium-fabric:${project.sodium_version}"
1817
// ^ Change to `modCompileOnly` to test without sodium

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ java_version=21
3636

3737
# Mod Menu
3838
# https://modrinth.com/mod/modmenu/versions
39-
modmenu_version=16.0.0-rc.1
39+
modmenu_version=17.0.0-beta.1
4040

4141
# Fabric Compatibility
4242
# https://fabricmc.net/develop/

0 commit comments

Comments
 (0)