GCLOUD2-5422 allow renaming bm instances

Author: alex2304

docs/resources/gcore_baremetal.md

@@ -50,7 +50,6 @@ resource "gcore_baremetal" "bm" {
 
 - **flavor_id** (String)
 - **interface** (Block Set, Min: 1) (see [below for nested schema](#nestedblock--interface))
-- **name** (String)
 
 ### Optional
 
@@ -62,6 +61,7 @@ resource "gcore_baremetal" "bm" {
 - **last_updated** (String)
 - **metadata** (Block List, Deprecated) (see [below for nested schema](#nestedblock--metadata))
 - **metadata_map** (Map of String)
+- **name** (String)
 - **name_templates** (String)
 - **password** (String)
 - **project_id** (Number)

gcore/resource_gcore_baremetal.go

@@ -89,11 +89,20 @@ func resourceBmInstance() *schema.Resource {
 			},
 			"name": &schema.Schema{
 				Type:     schema.TypeString,
-				Required: true,
+				Optional: true,
+				Computed: true,
+				ExactlyOneOf: []string{
+					"name",
+					"name_templates",
+				},
 			},
 			"name_templates": &schema.Schema{
 				Type:     schema.TypeString,
 				Optional: true,
+				ExactlyOneOf: []string{
+					"name",
+					"name_templates",
+				},
 			},
 			"image_id": {
 				Type:     schema.TypeString,
@@ -293,7 +302,6 @@ func resourceBmInstanceCreate(ctx context.Context, d *schema.ResourceData, m int
 	log.Printf("[DEBUG] Baremetal interfaces: %+v", newInterface)
 	opts := bminstances.CreateOpts{
 		Flavor:        d.Get("flavor_id").(string),
-		Names:         []string{d.Get("name").(string)},
 		ImageID:       d.Get("image_id").(string),
 		AppTemplateID: d.Get("apptemplate_id").(string),
 		Keypair:       d.Get("keypair_name").(string),
@@ -304,6 +312,11 @@ func resourceBmInstanceCreate(ctx context.Context, d *schema.ResourceData, m int
 		Interfaces:    newInterface,
 	}
 
+	name := d.Get("name").(string)
+	if len(name) > 0 {
+		opts.Names = []string{name}
+	}
+
 	nameTpl := d.Get("name_templates").(string)
 	if len(nameTpl) > 0 {
 		opts.NameTemplates = []string{nameTpl}
@@ -547,6 +560,18 @@ func resourceBmInstanceUpdate(ctx context.Context, d *schema.ResourceData, m int
 		return diag.FromErr(err)
 	}
 
+	if d.HasChange("name") {
+		nameTemplate := d.Get("name_templates").(string)
+		if len(nameTemplate) == 0 {
+			opts := instances.RenameInstanceOpts{
+				Name: d.Get("name").(string),
+			}
+			if _, err := instances.RenameInstance(client, instanceID, opts).Extract(); err != nil {
+				return diag.FromErr(err)
+			}
+		}
+	}
+
 	if d.HasChange("metadata") {
 		omd, nmd := d.GetChange("metadata")
 		if len(omd.([]interface{})) > 0 {