security_group data source fixed

Author: 0ndi

docs/index.md

@@ -18,7 +18,7 @@ terraform {
   required_providers {
     gcore = {
       source  = "G-Core/gcorelabs"
-      version = "0.1.2"
+      version = "0.1.3"
     }
   }
 }

examples/provider/provider.tf

@@ -3,7 +3,7 @@ terraform {
   required_providers {
     gcore = {
       source  = "G-Core/gcorelabs"
-      version = "0.1.2"
+      version = "0.1.3"
     }
   }
 }

gcore/data_source_gcore_securitygroup.go

@@ -153,10 +153,12 @@ func dataSourceSecurityGroupRead(ctx context.Context, d *schema.ResourceData, m
 		r["id"] = sgr.ID
 		r["direction"] = sgr.Direction.String()
 
+		r["ethertype"] = ""
 		if sgr.EtherType != nil {
 			r["ethertype"] = sgr.EtherType.String()
 		}
 
+		r["protocol"] = types.ProtocolAny.String()
 		if sgr.Protocol != nil {
 			r["protocol"] = sgr.Protocol.String()
 		}

gcore/utils.go

@@ -268,7 +268,7 @@ func findProjectByName(arr []projects.Project, name string) (int, error) {
 			return el.ID, nil
 		}
 	}
-	return 0, fmt.Errorf("Region with name %s not found", name)
+	return 0, fmt.Errorf("project with name %s not found", name)
 }
 
 //GetProject returns valid projectID for a resource
@@ -306,7 +306,7 @@ func findRegionByName(arr []regions.Region, name string) (int, error) {
 			return el.ID, nil
 		}
 	}
-	return 0, fmt.Errorf("Region with name %s not found", name)
+	return 0, fmt.Errorf("region with name %s not found", name)
 }
 
 //GetRegion returns valid regionID for a resource
@@ -321,12 +321,12 @@ func GetRegion(provider *gcorecloud.ProviderClient, regionID int, regionName str
 		Project: 0,
 		Version: "v1",
 	})
-	regions, err := regions.ListAll(client)
+	rs, err := regions.ListAll(client)
 	if err != nil {
 		return 0, err
 	}
-	log.Printf("[DEBUG] Regions: %v", regions)
-	regionID, err = findRegionByName(regions, regionName)
+	log.Printf("[DEBUG] Regions: %v", rs)
+	regionID, err = findRegionByName(rs, regionName)
 	if err != nil {
 		return 0, err
 	}