golangci-lint config added

some fix after running linters
some fix in test, skipping k8s's tests in short mode

Author: [Partner] Alexander Sokolov

.golangci.yml

@@ -0,0 +1,41 @@
+run:
+  timeout: 60m
+  go: 1.17
+
+issues:
+  exclude-rules:
+    - linters:
+        - gosimple
+      text: "S1034"
+
+  max-per-linter: 0
+  max-same-issues: 0
+
+linters:
+  disable-all: true
+  enable:
+    - asciicheck
+    - deadcode
+    - errcheck
+    - gocritic
+    - goimports
+    - gosimple
+    - govet
+    - ineffassign
+    - nakedret
+    - misspell
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unused
+    - unconvert
+    - unparam
+    - varcheck
+    - vet
+    - vetshadow
+
+linters-settings:
+  errcheck:
+    ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,fmt:.*,io:Close,io:WriteString
+  nakedret:
+    max-func-lines: 40

GNUmakefile

@@ -41,6 +41,9 @@ doc-generate:
 fmt:
 	gofmt -w $(GOFMT_FILES)
 
+linters:
+	golangci-lint run ./...
+
 fmtcheck:
 	@sh -c "'$(CURDIR)/scripts/gofmtcheck.sh'"
 

docs/data-sources/gcore_k8s.md

@@ -47,6 +47,7 @@ data "gcore_k8s" "v" {
 - `container_version` (String)
 - `created_at` (String)
 - `discovery_url` (String)
+- `external_dns_enabled` (Boolean)
 - `faults` (Map of String)
 - `fixed_network` (String)
 - `fixed_subnet` (String)

gcore/data_source_gcore_k8s.go

@@ -68,10 +68,10 @@ func dataSourceK8s() *schema.Resource {
 				Type:     schema.TypeBool,
 				Computed: true,
 			},
-			//"external_dns_enabled": &schema.Schema{
-			//	Type:     schema.TypeBool,
-			//	Computed: true,
-			//},
+			"external_dns_enabled": &schema.Schema{
+				Type:     schema.TypeBool,
+				Computed: true,
+			},
 			"master_lb_floating_ip_enabled": &schema.Schema{
 				Type:     schema.TypeBool,
 				Computed: true,
@@ -233,7 +233,7 @@ func dataSourceK8sRead(ctx context.Context, d *schema.ResourceData, m interface{
 	d.Set("node_count", cluster.NodeCount)
 	d.Set("status", cluster.Status)
 	d.Set("status_reason", cluster.StatusReason)
-	//d.Set("external_dns_enabled", cluster.ExternalDNSEnabled)
+	d.Set("external_dns_enabled", cluster.ExternalDNSEnabled)
 
 	masterAddresses := make([]string, len(cluster.MasterAddresses))
 	for i, addr := range cluster.MasterAddresses {

gcore/data_source_gcore_k8s_pool_test.go

@@ -19,6 +19,9 @@ import (
 )
 
 func TestAccK8sPoolDataSource(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skipping test in short mode")
+	}
 	cfg, err := createTestConfig()
 	if err != nil {
 		t.Fatal(err)

gcore/data_source_gcore_k8s_test.go

@@ -26,7 +26,7 @@ import (
 
 const (
 	testClusterName      = "test-cluster"
-	testClusterVersion   = "1.20.6"
+	testClusterVersion   = "1.20.15"
 	testClusterPoolName  = "test-pool"
 	testPoolFlavor       = "g1-standard-1-2"
 	testNodeCount        = 1
@@ -39,6 +39,9 @@ const (
 )
 
 func TestAccK8sDataSource(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skipping test in short mode")
+	}
 	fullName := "data.gcore_k8s.acctest"
 
 	cfg, err := createTestConfig()

gcore/data_source_gcore_network.go

@@ -93,11 +93,11 @@ func dataSourceNetworkRead(ctx context.Context, d *schema.ResourceData, m interf
 		return diag.FromErr(err)
 	}
 
-	//todo refactor, also refactor inner func
+	// todo refactor, also refactor inner func
 	var rawNetwork map[string]interface{}
 	network, found := findNetworkByName(name, nets)
 	if !found {
-		//trying to find among shared networks
+		// trying to find among shared networks
 		nets, err := availablenetworks.ListAll(clientShared, nil)
 		if err != nil {
 			return diag.FromErr(err)

gcore/data_source_gcore_reservedfixedip.go

@@ -134,7 +134,7 @@ func dataSourceReservedFixedIPRead(ctx context.Context, d *schema.ResourceData,
 		return diag.Errorf("reserved fixed ip %s not found", ipAddr)
 	}
 
-	//should we use PortID as id?
+	// should we use PortID as id?
 	d.SetId(reservedFixedIP.PortID)
 	d.Set("project_id", reservedFixedIP.ProjectID)
 	d.Set("region_id", reservedFixedIP.RegionID)

gcore/data_source_gcore_storage_s3.go

@@ -1,10 +1,11 @@
 package gcore
 
 import (
+	"regexp"
+
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"regexp"
 )
 
 func dataSourceStorageS3() *schema.Resource {

gcore/data_source_gcore_storage_sftp.go

@@ -1,10 +1,11 @@
 package gcore
 
 import (
+	"regexp"
+
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	"regexp"
 )
 
 func dataSourceStorageSFTP() *schema.Resource {