Skip to content
This repository was archived by the owner on Mar 1, 2023. It is now read-only.

Commit cb78947

Browse files
author
Alexandr Sokolov
committed
instance and reservedfixedip deletion fixed
1 parent 0480230 commit cb78947

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

gcore/provider_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ func createTestConfig() (*Config, error) {
381381
DNSClient: dnsClient,
382382
}
383383

384-
return &config, err
384+
return &config, nil
385385
}
386386

387387
func testAccCheckResourceExists(resourceName string) resource.TestCheckFunc {

gcore/resource_gcore_instance.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -922,8 +922,6 @@ func resourceInstanceDelete(ctx context.Context, d *schema.ResourceData, m inter
922922
}
923923

924924
var delOpts instances.DeleteOpts
925-
delOpts.DeleteFloatings = true
926-
927925
results, err := instances.Delete(client, instanceID, delOpts).Extract()
928926
if err != nil {
929927
return diag.FromErr(err)

gcore/resource_gcore_reservedfixedip.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,14 @@ func resourceReservedFixedIPDelete(ctx context.Context, d *schema.ResourceData,
322322
id := d.Id()
323323
results, err := reservedfixedips.Delete(client, id).Extract()
324324
if err != nil {
325-
return diag.FromErr(err)
325+
switch err.(type) {
326+
case gcorecloud.ErrDefault404:
327+
d.SetId("")
328+
log.Printf("[DEBUG] Finish of ReservedFixedIP deleting")
329+
return diags
330+
default:
331+
return diag.FromErr(err)
332+
}
326333
}
327334

328335
taskID := results.Tasks[0]

0 commit comments

Comments
 (0)