linter minor fix

Author: Alexandr Sokolov

gcore/data_source_gcore_image.go

@@ -99,7 +99,7 @@ func dataSourceImageRead(ctx context.Context, d *schema.ResourceData, m interfac
 
 	allImages, err := images.ListAll(client, images.ListOpts{})
 	if err != nil {
-
+		return diag.FromErr(err)
 	}
 
 	var found bool

gcore/provider_test.go

@@ -302,7 +302,7 @@ func objectInfo(resourceType string) string {
 
 func CreateTestClient(provider *gcorecloud.ProviderClient, endpoint, version string) (*gcorecloud.ServiceClient, error) {
 	projectID := 0
-	err := fmt.Errorf("")
+	var err error
 	if strProjectID, exists := os.LookupEnv("TEST_PROJECT_ID"); exists {
 		projectID, err = strconv.Atoi(strProjectID)
 		if err != nil {
@@ -348,6 +348,9 @@ func createTestConfig() (*Config, error) {
 		Password:    os.Getenv("GCORE_PASSWORD"),
 		AllowReauth: true,
 	})
+	if err != nil {
+		return nil, err
+	}
 
 	cdnProvider := gcdnProvider.NewClient(GCORE_CDN_URL, gcdnProvider.WithSignerFunc(func(req *http.Request) error {
 		req.Header.Set("Authorization", "Bearer "+provider.AccessToken())

gcore/resource_gcore_baremetal.go

@@ -513,7 +513,7 @@ func resourceBmInstanceRead(ctx context.Context, d *schema.ResourceData, m inter
 	} else {
 		metadata := d.Get("metadata_map").(map[string]interface{})
 		newMetadata := make(map[string]interface{}, len(metadata))
-		for k, _ := range metadata {
+		for k := range metadata {
 			md, err := instances.MetadataGet(client, instanceID, k).Extract()
 			if err != nil {
 				return diag.Errorf("cannot get metadata with key: %s. Error: %s", instanceID, err)
@@ -604,7 +604,7 @@ func resourceBmInstanceUpdate(ctx context.Context, d *schema.ResourceData, m int
 	} else if d.HasChange("metadata_map") {
 		omd, nmd := d.GetChange("metadata_map")
 		if len(omd.(map[string]interface{})) > 0 {
-			for k, _ := range omd.(map[string]interface{}) {
+			for k := range omd.(map[string]interface{}) {
 				err := instances.MetadataDelete(client, instanceID, k).Err
 				if err != nil {
 					return diag.Errorf("cannot delete metadata key: %s. Error: %s", k, err)

gcore/resource_gcore_instance.go

@@ -602,7 +602,7 @@ func resourceInstanceRead(ctx context.Context, d *schema.ResourceData, m interfa
 	} else {
 		metadata := d.Get("metadata_map").(map[string]interface{})
 		newMetadata := make(map[string]interface{}, len(metadata))
-		for k, _ := range metadata {
+		for k := range metadata {
 			md, err := instances.MetadataGet(client, instanceID, k).Extract()
 			if err != nil {
 				return diag.Errorf("cannot get metadata with key: %s. Error: %s", instanceID, err)
@@ -710,7 +710,7 @@ func resourceInstanceUpdate(ctx context.Context, d *schema.ResourceData, m inter
 	} else if d.HasChange("metadata_map") {
 		omd, nmd := d.GetChange("metadata_map")
 		if len(omd.(map[string]interface{})) > 0 {
-			for k, _ := range omd.(map[string]interface{}) {
+			for k := range omd.(map[string]interface{}) {
 				err := instances.MetadataDelete(client, instanceID, k).Err
 				if err != nil {
 					return diag.Errorf("cannot delete metadata key: %s. Error: %s", k, err)

gcore/resource_gcore_router.go

@@ -295,7 +295,7 @@ func resourceRouterRead(ctx context.Context, d *schema.ResourceData, m interface
 		ifs[i] = smap
 	}
 	if err := d.Set("interfaces", schema.NewSet(routerInterfaceUniqueID, ifs)); err != nil {
-
+		return diag.FromErr(err)
 	}
 
 	rs := make([]map[string]string, len(router.Routes))

gcore/resource_gcore_volume.go

@@ -319,6 +319,10 @@ func ExtendVolume(client *gcorecloud.ServiceClient, volumeID string, newSize int
 		Size: newSize,
 	}
 	results, err := volumes.Extend(client, volumeID, opts).Extract()
+	if err != nil {
+		return err
+	}
+
 	taskID := results.Tasks[0]
 	log.Printf("[DEBUG] Task id (%s)", taskID)
 	_, err = tasks.WaitTaskAndReturnResult(client, taskID, true, volumeExtending, func(task tasks.TaskID) (interface{}, error) {

gcore/utils.go

@@ -387,6 +387,10 @@ func GetRegion(provider *gcorecloud.ProviderClient, regionID int, regionName str
 		Project: 0,
 		Version: "v1",
 	})
+	if err != nil {
+		return 0, err
+	}
+
 	rs, err := regions.ListAll(client)
 	if err != nil {
 		return 0, err
@@ -554,24 +558,6 @@ func extractHealthMonitorMap(d *schema.ResourceData) *lbpools.CreateHealthMonito
 	return healthOpts
 }
 
-func interfaceUniqueID(i interface{}) int {
-	e := i.(map[string]interface{})
-	h := md5.New()
-	iType := e["type"].(string)
-	io.WriteString(h, iType)
-	iOrder, _ := e["order"].(int)
-	io.WriteString(h, strconv.Itoa(iOrder))
-	switch types.InterfaceType(iType) {
-	case types.ReservedFixedIpType:
-		io.WriteString(h, e["port_id"].(string))
-	case types.AnySubnetInterfaceType:
-		io.WriteString(h, e["network_id"].(string))
-	case types.SubnetInterfaceType:
-		io.WriteString(h, e["subnet_id"].(string))
-	}
-	return int(binary.BigEndian.Uint64(h.Sum(nil)))
-}
-
 func routerInterfaceUniqueID(i interface{}) int {
 	e := i.(map[string]interface{})
 	h := md5.New()