Skip to content

Commit e1fe81b

Browse files
authored
Merge pull request #94 from pavelsne/bids_error
[results.go] Fixed err page for BIDS validation
2 parents 6883604 + 144ef3c commit e1fe81b

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

internal/resources/templates/bids_results.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@ const BidsResults = `
6767
</div>
6868
{{ end }}
6969
70+
{{ if .ErrorMessage }}
71+
<div class="ui message red">
72+
{{ .ErrorMessage }}
73+
</div>
74+
{{ end }}
75+
7076
{{ if .Summary }}
7177
<div>Summary</div>
7278
<div>Sessions: {{ .Summary.Sessions }}</div>

internal/web/results.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,10 @@ func renderBIDSResults(w http.ResponseWriter, r *http.Request, badge []byte, con
306306
// Parse results file
307307
var resBIDS BidsResultStruct
308308
err := json.Unmarshal(content, &resBIDS)
309+
errMsg := ""
309310
if err != nil {
310311
log.ShowWrite("[Error] unmarshalling '%s/%s' result: %s\n", user, repo, err.Error())
311-
http.ServeContent(w, r, "unavailable", time.Now(), bytes.NewReader([]byte("500 Something went wrong...")))
312-
return
312+
errMsg = "Could not validate format as BIDS."
313313
}
314314

315315
// Parse html template
@@ -341,7 +341,8 @@ func renderBIDSResults(w http.ResponseWriter, r *http.Request, badge []byte, con
341341
CurrentYear int
342342
UserName string
343343
*ResultsHistoryStruct
344-
}{template.HTML(badge), head, &resBIDS, srvcfg.GINAddresses.WebURL, year, loggedUsername, &resHistory}
344+
ErrorMessage string
345+
}{template.HTML(badge), head, &resBIDS, srvcfg.GINAddresses.WebURL, year, loggedUsername, &resHistory, errMsg}
345346

346347
err = tmpl.ExecuteTemplate(w, "layout", info)
347348
if err != nil {

0 commit comments

Comments
 (0)