Skip to content

Commit 0a9f7ea

Browse files
committed
[Matlab] Refactor Dimensions index use
1 parent 7059707 commit 0a9f7ea

File tree

3 files changed

+13
-23
lines changed

3 files changed

+13
-23
lines changed

+nix/RangeDimension.m

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@
2727
end
2828

2929
function r = tick_at(obj, index)
30-
if (index > 0)
31-
index = index - 1;
32-
end
30+
index = nix.Utils.handle_index(index);
3331
fname = strcat(obj.alias, '::tickAt');
3432
r = nix_mx(fname, obj.nix_handle, index);
3533
end
@@ -41,12 +39,10 @@
4139

4240
function r = axis(obj, count, startIndex)
4341
if (nargin < 3)
44-
startIndex = 0;
42+
startIndex = 1;
4543
end
4644

47-
if (startIndex > 0)
48-
startIndex = startIndex - 1;
49-
end
45+
startIndex = nix.Utils.handle_index(startIndex);
5046

5147
fname = strcat(obj.alias, '::axis');
5248
r = nix_mx(fname, obj.nix_handle, count, startIndex);

+nix/SampledDimension.m

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,23 +32,17 @@
3232
end
3333

3434
function r = position_at(obj, index)
35-
if (index > 0)
36-
index = index - 1;
37-
end
38-
35+
index = nix.Utils.handle_index(index);
3936
fname = strcat(obj.alias, '::positionAt');
4037
r = nix_mx(fname, obj.nix_handle, index);
4138
end
4239

4340
function r = axis(obj, count, startIndex)
4441
if (nargin < 3)
45-
startIndex = 0;
46-
end
47-
48-
if (startIndex > 0)
49-
startIndex = startIndex - 1;
42+
startIndex = 1;
5043
end
5144

45+
startIndex = nix.Utils.handle_index(startIndex);
5246
fname = strcat(obj.alias, '::axis');
5347
r = nix_mx(fname, obj.nix_handle, count, startIndex);
5448
end

tests/TestDimensions.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
assert(d1.samplingInterval == 200);
6666
assert(isempty(d1.offset));
6767

68-
axis = d1.axis(10, 0);
68+
axis = d1.axis(10, 1);
6969
assert(axis(1) == 0);
7070
assert(length(axis) == 10);
7171
assert(axis(end) == (length(axis) - 1) * d1.samplingInterval);
@@ -80,12 +80,12 @@
8080
assert(d1.samplingInterval == 325);
8181
assert(d1.offset == 500);
8282

83-
axis = d1.axis(10, 0);
83+
axis = d1.axis(10, 1);
8484
assert(axis(1) == d1.offset);
8585
assert(length(axis) == 10);
8686
assert(axis(end) == (length(axis) - 1) * d1.samplingInterval + d1.offset);
8787

88-
assert(d1.position_at(0) == d1.offset);
88+
assert(d1.position_at(1) == d1.offset);
8989
assert(d1.position_at(10) == d1.offset + 9 * d1.samplingInterval);
9090

9191
d1.label = '';
@@ -97,11 +97,11 @@
9797
assert(d1.samplingInterval == 325);
9898
assert(d1.offset == 0);
9999

100-
axis = d1.axis(10, 0);
100+
axis = d1.axis(10, 1);
101101
assert(axis(1) == 0);
102102
assert(axis(end) == (length(axis) - 1) * d1.samplingInterval + d1.offset);
103103

104-
assert(d1.position_at(0) == d1.offset);
104+
assert(d1.position_at(1) == d1.offset);
105105
assert(d1.position_at(10) == d1.offset + 9 * d1.samplingInterval);
106106
end
107107

@@ -119,12 +119,12 @@
119119
assert(isempty(d1.unit));
120120
assert(isequal(d1.ticks, ticks));
121121

122-
axis = d1.axis(3, 0);
122+
axis = d1.axis(3, 1);
123123
assert(axis(1) == ticks(1));
124124
assert(length(axis) == 3);
125125
assert(axis(end) == ticks(length(axis)));
126126

127-
assert(d1.tick_at(0) == ticks(1));
127+
assert(d1.tick_at(1) == ticks(1));
128128
assert(d1.tick_at(3) == ticks(3));
129129

130130
new_ticks = [5 6 7 8];

0 commit comments

Comments
 (0)