Skip to content

Commit b9b7442

Browse files
authored
Merge pull request #160 from mpsonntag/removeMapping
lgtm
2 parents c4219c2 + b4a0147 commit b9b7442

File tree

7 files changed

+2
-21
lines changed

7 files changed

+2
-21
lines changed

+nix/Property.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525

2626
% assign dynamic properties
2727
nix.Dynamic.add_dyn_attr(obj, 'unit', 'rw');
28-
nix.Dynamic.add_dyn_attr(obj, 'mapping', 'rw');
2928
nix.Dynamic.add_dyn_attr(obj, 'datatype', 'r');
3029
end
3130

+nix/Section.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
% assign dynamic properties
2323
nix.Dynamic.add_dyn_attr(obj, 'repository', 'rw');
24-
nix.Dynamic.add_dyn_attr(obj, 'mapping', 'rw');
2524

2625
% assign relations
2726
nix.Dynamic.add_dyn_relation(obj, 'sections', @nix.Section);

nix_mx.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,6 @@ void mexFunction(int nlhs,
411411
.reg("setNoneDefinition", SETTER(const boost::none_t, nix::Section, definition))
412412
.reg("setRepository", SETTER(const std::string&, nix::Section, repository))
413413
.reg("setNoneRepository", SETTER(const boost::none_t, nix::Section, repository))
414-
.reg("setMapping", SETTER(const std::string&, nix::Section, mapping))
415-
.reg("setNoneMapping", SETTER(const boost::none_t, nix::Section, mapping))
416414
.reg("createSection", &nix::Section::createSection)
417415
.reg("deleteSection", REMOVER(nix::Section, nix::Section, deleteSection))
418416
.reg("openProperty", GETBYSTR(nix::Property, nix::Section, getProperty))
@@ -443,8 +441,6 @@ void mexFunction(int nlhs,
443441
.reg("setNoneDefinition", SETTER(const boost::none_t, nix::Property, definition))
444442
.reg("setUnit", SETTER(const std::string&, nix::Property, unit))
445443
.reg("setNoneUnit", SETTER(const boost::none_t, nix::Property, unit))
446-
.reg("setMapping", SETTER(const std::string&, nix::Property, mapping))
447-
.reg("setNoneMapping", SETTER(const boost::none_t, nix::Property, mapping))
448444
.reg("valueCount", GETTER(nix::ndsize_t, nix::Property, valueCount))
449445
.reg("setNoneValue", SETTER(const boost::none_t, nix::Property, values));
450446

src/nixproperty.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@
1818
namespace nixproperty {
1919

2020
mxArray *describe(const nix::Property &prop) {
21-
struct_builder sb({ 1 }, { "id", "name", "definition", "unit", "mapping", "datatype" });
21+
struct_builder sb({ 1 }, { "id", "name", "definition", "unit", "datatype" });
2222

2323
sb.set(prop.id());
2424
sb.set(prop.name());
2525
sb.set(prop.definition());
2626
sb.set(prop.unit());
27-
sb.set(prop.mapping());
2827
sb.set(string_nix2mex(prop.dataType()));
2928

3029
return sb.array();

src/nixsection.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,14 @@ namespace nixsection {
2121

2222
mxArray *describe(const nix::Section &section) {
2323
struct_builder sb({ 1 }, {
24-
"name", "id", "type", "definition", "repository", "mapping"
24+
"name", "id", "type", "definition", "repository"
2525
});
2626

2727
sb.set(section.name());
2828
sb.set(section.id());
2929
sb.set(section.type());
3030
sb.set(section.definition());
3131
sb.set(section.repository());
32-
sb.set(section.mapping());
3332

3433
return sb.array();
3534
}

tests/TestProperty.m

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,19 @@
3131

3232
assert(isempty(p.definition));
3333
assert(isempty(p.unit));
34-
assert(isempty(s.mapping));
3534

3635
p.definition = 'property definition';
3736
p.unit = 'ms';
38-
p.mapping = 'property mapping';
3937
assert(strcmp(p.definition, 'property definition'));
4038
assert(strcmp(p.unit, 'ms'));
41-
assert(strcmp(p.mapping, 'property mapping'));
4239

4340
p.definition = 'next property definition';
4441
p.unit = 'mm';
45-
p.mapping = 'next property mapping';
4642

4743
p.definition = '';
4844
p.unit = '';
49-
p.mapping = '';
5045
assert(isempty(p.definition));
5146
assert(isempty(p.unit));
52-
assert(isempty(s.mapping));
5347
end
5448

5549
%% Test: Access values

tests/TestSection.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,24 +159,19 @@
159159
assert(strcmp(s.name, 'foo'));
160160
assert(strcmp(s.type, 'bar'));
161161
assert(isempty(s.repository));
162-
assert(isempty(s.mapping));
163162
assert(isempty(s.definition));
164163

165164
s.type = 'nixBlock';
166165
s.definition = 'section definition';
167166
s.repository = 'rep1';
168-
s.mapping = 'map1';
169167
assert(strcmp(s.type, 'nixBlock'));
170168
assert(strcmp(s.definition, 'section definition'));
171169
assert(strcmp(s.repository, 'rep1'));
172-
assert(strcmp(s.mapping, 'map1'));
173170

174171
s.definition = '';
175172
s.repository = '';
176-
s.mapping = '';
177173
assert(isempty(s.definition));
178174
assert(isempty(s.repository));
179-
assert(isempty(s.mapping));
180175
end
181176

182177
function [] = test_properties( varargin )

0 commit comments

Comments
 (0)