[Matlab] Consistent 'isa' class comparison use

Author: mpsonntag

+nix/Block.m

@@ -267,7 +267,7 @@
 
         %-- Creating a multitag requires an already existing data array
         function r = create_multi_tag(obj, name, type, add_data_array)
-            if (strcmp(class(add_data_array), 'nix.DataArray'))
+            if (isa(add_data_array, 'nix.DataArray'))
                 addID = add_data_array.id;
             else
                 addID = add_data_array;

+nix/DataArray.m

@@ -14,7 +14,7 @@
         alias = 'DataArray'
     end
 
-    properties(Dependent)
+    properties (Dependent)
         dimensions % should not be dynamic due to complex set operation
     end
 

+nix/Feature.m

@@ -14,7 +14,7 @@
         alias = 'Feature'
     end
 
-    properties(Dependent)
+    properties (Dependent)
         id
         linkType
     end
@@ -45,7 +45,7 @@
         end
 
         function [] = set_data(obj, setData)
-            if (strcmp(class(setData), 'nix.DataArray'))
+            if (isa(setData, 'nix.DataArray'))
                 setData = setData.id;
             end
             fname = strcat(obj.alias, '::setData');

+nix/MultiTag.m

@@ -89,7 +89,7 @@
         % ------------------
 
         function r = add_feature(obj, add_this, link_type)
-            if (strcmp(class(add_this), 'nix.DataArray'))
+            if (isa(add_this, 'nix.DataArray'))
                 addID = add_this.id;
             else
                 addID = add_this;

+nix/NamedEntity.m

@@ -24,7 +24,7 @@
         function r = compare(obj, entity)
         % Compares first name and second id, return > 0 if the entity 
         % is larger than the other, 0 if both are equal, and < 0 otherwise.
-            if (~strcmp(class(obj), class(entity)))
+            if (~isa(obj, class(entity)))
                 error('Only entities of the same class can be compared.');
             end
             fname = strcat(obj.alias, '::compare');

+nix/Property.m

@@ -10,12 +10,12 @@
     % PROPERTY Metadata Property class
     %   NIX metadata property
 
-    properties(Hidden)
+    properties (Hidden)
         % namespace reference for nix-mx functions
         alias = 'Property'
     end
 
-    properties(Dependent)
+    properties (Dependent)
         values
     end
 
@@ -69,7 +69,7 @@
         % return value 0 means name and id of two properties are
         % identical, any other value means either name or id differ.
         function r = compare(obj, property)
-            if (~strcmp(class(property), class(obj)))
+            if (~isa(property, class(obj)))
                error('Function only supports comparison of Properties.');
             end
 

+nix/Section.m

@@ -10,7 +10,7 @@
     % SECTION Metadata Section class
     %   NIX metadata section
 
-    properties(Hidden)
+    properties (Hidden)
         % namespace reference for nix-mx functions
         alias = 'Section'
     end
@@ -143,7 +143,7 @@
         function r = delete_property(obj, del)
             if (isstruct(del) && isfield(del, 'id'))
                 delID = del.id;
-            elseif (strcmp(class(del), 'nix.Property'))
+            elseif (isa(del, 'nix.Property'))
                 delID = del.id;
             else
                 delID = del;
@@ -203,16 +203,15 @@
     % Referring utility method
     % ----------------
 
-    methods(Access=protected)
+    methods (Access=protected)
         % referring_util receives a nix entityConstructor, part of a function
         % name and varargin to provide abstract access to nix.Section
         % referringXXX and referringXXX(Block) methods.
         function r = referring_util(obj, entityConstructor, fsuffix, varargin)
             if (isempty(varargin))
                 fname = strcat(obj.alias, '::referring', fsuffix);
                 r = nix.Utils.fetchObjList(fname, obj.nix_handle, entityConstructor);
-            elseif ((size(varargin, 2) > 1) || ...
-                    (~strcmp(class(varargin{1}), 'nix.Block')))
+            elseif ((size(varargin, 2) > 1) || (~isa(varargin{1}, 'nix.Block')))
                 error('Provide either empty arguments or a single Block entity');
             else
                 fname = strcat(obj.alias, '::referringBlock', fsuffix);

+nix/SourcesMixIn.m

@@ -27,7 +27,7 @@
         % has_source supports only check by id, not by name
         function r = has_source(obj, id_or_entity)
             has = id_or_entity;
-            if (strcmp(class(has), 'nix.Source'))
+            if (isa(has, 'nix.Source'))
             	has = id_or_entity.id;
             end
 

+nix/Tag.m

@@ -91,7 +91,7 @@
         % ------------------
 
         function r = add_feature(obj, add_this, link_type)
-            if (strcmp(class(add_this), 'nix.DataArray'))
+            if (isa(add_this, 'nix.DataArray'))
                 addID = add_this.id;
             else
                 addID = add_this;

+nix/Utils.m

@@ -40,7 +40,7 @@
         end
 
         function [] = add_entity(obj, add_this, nixEntity, mxMethod)
-            if (strcmp(class(add_this), nixEntity))
+            if (isa(add_this, nixEntity))
                 addID = add_this.id;
             else
                 addID = add_this;
@@ -66,7 +66,7 @@
         % The first actually removes the entity, the latter
         % removes only the reference to the entity.
         function r = delete_entity(obj, del, nixEntity, mxMethod)
-            if (strcmp(class(del), nixEntity))
+            if (isa(del, nixEntity))
                 delID = del.id;
             else
                 delID = del;