Skip to content

Commit 474d76a

Browse files
committed
[docs] fixes as suggested by code review
1 parent df3f85d commit 474d76a

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

docs/source/faq.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ Q: What does this error mean? “Cannot open a nonexistent file in ReadOnly mode
1414
-------------------------------------------------------------------------------
1515

1616
Arises when the provided file path is invalid and you try to open it
17-
with the nix::FileMode::ReadOnly mode. Solution: provide the path to an
18-
existing file to be opened in ``nix::ReadOnly`` mode or use the
19-
``nix::FileMode::ReadWrite`` or ``nix::FileMode::Overwrite`` flag to
17+
with the nixio.FileMode.ReadOnly mode. Solution: provide the path to an
18+
existing file to be opened in ``nixio.FileMode.ReadOnly`` mode or use the
19+
``nixio.FileMode.ReadWrite`` or ``nixio.FileMode.Overwrite`` flag to
2020
create a new one.
2121

2222
Q: Is it ok to use non-SI units?

docs/source/image_data.rst

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,10 @@ One key feature of the nix-model is its ability to annotate, or "tag", points or
3333
Tagging a single point or region
3434
--------------------------------
3535

36-
Single points of regions-of-interest are annotated using a **Tag**
37-
object. The Tag contains the start *position* and, optional, the
38-
*extent* of the point or region. The link to the data is established
39-
by adding the **DataArray** that contains the data to the list of
40-
references. It is important to note that *position* and *extent* are
41-
arrays with the length matching the dimensionality of the referenced
42-
data. The same Tag can be applied to many references as long as
43-
*position* and *extent* can be applied to these.
36+
Single points of regions-of-interest are annotated using a **Tag** object. The Tag contains the start *position* and, optional, the *extent* of the point or region. The link to the data is established by adding the **DataArray** that contains the data to the list of references. It is important to note that *position* and *extent* are arrays with the length matching the dimensionality of the referenced data. The same Tag can be applied to many references as long as *position* and *extent* can be applied to these.
4437

4538
.. literalinclude:: examples/singleROI.py
46-
:lines: 80-84
39+
:lines: 77-81
4740
:caption: A *Tag* is used to tag a a single region of interest. Most image data is 3-D with the third dimension representing the color channels (:download:`singleROI.py <examples/singleROI.py>`).
4841

4942
.. image:: images/single_roi.png

docs/source/news.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Pass ``quiet=False`` in order to get some feedback on what the tool did. **Note:
5050
Model changes
5151
#############
5252

53-
* the metadata model was simplified to reflect the changes introduced to the underlying **odml** data model. Accordingly the *Value* entity does no longer exist. New versions of the library can read but not write old data. Experience showed that almost all use cases stored single Values in a *Property*. The overhead (code and also file size) of keeping each value in a separate Entitiy is not justified. The *Property* now keeps all information that was Value related, such as the uncertainty. If you want to store multiple values in a property this is still possible but they have to have the same data type. (see :ref:`Annotations with arbitrary metadata` for more information).
53+
* the metadata model was simplified to reflect the changes introduced to the underlying **odml** data model. Accordingly the *Value* entity does no longer exist. New versions of the library can read but not write old data. Experience showed that almost all use cases stored single Values in a *Property*. The overhead (code and also file size) of keeping each value in a separate Entity is not justified. The *Property* now keeps all information that was Value related, such as the uncertainty. If you want to store multiple values in a property this is still possible but they have to have the same data type. (see :ref:`Annotations with arbitrary metadata` for more information).
5454
* New *DataFrame* entity that stores tabular data. Each column has a name, unit, and data type. (see :ref:`The DataFrame` for more information).
5555
* *Tags* and *MultiTags* can link to DataFrames as features.
5656
* *RangeDimensions* ticks can now be stored within the dimension descriptor, or in linked DataArrays or DataFrames. Ticks must still be one-dimensional (see :ref:`RangeDimension` for more information).

docs/source/storing_data.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ Data is read from a DataArray by accessing it in numpy style.
109109

110110
.. code-block:: python
111111
112-
data_array = block.create_data_array("test data", "test", data=np.random.randn(100))
112+
array = block.create_data_array("test data", "test", data=np.random.randn(100))
113113
print(array.shape)
114-
data_array.append(np.ones(100))
114+
array.append(np.ones(100))
115115
print(array.shape)
116116
117117

0 commit comments

Comments
 (0)