only accept list-like labels with string items

Author: sprenger

nixio/data_array.py

@@ -91,10 +91,11 @@ def append_set_dimension(self, labels=None):
         index = len(self.dimensions) + 1
         setdim = SetDimension.create_new(self, index)
         if labels is not None:
-            if not hasattr(labels, '__iter__'):
-                labels = str(labels)
-            if isinstance(labels, str):
-                labels = [labels]
+            if not hasattr(labels, '__iter__') or isinstance(labels, str):
+                raise ValueError('`labels` has to be a list-like object.')
+            for label in labels:
+                if not isinstance(label, str):
+                    raise ValueError(f'`labels` has to contain string objects, not {type(label)}')
             if not isinstance(labels, list):
                 labels = list(labels)
             setdim.labels = labels

nixio/test/test_dimensions.py

@@ -158,15 +158,16 @@ def test_set_dim_labels_array(self):
         setdim = self.array.append_set_dimension(labels)
         assert tuple(labels) == setdim.labels
 
-    def test_set_dim_labels_single_string(self):
-        labels = 'Sample 1'
-        setdim = self.array.append_set_dimension(labels)
-        assert tuple([labels]) == setdim.labels
+    def test_set_dim_invalid_labels(self):
+        # don't accept non list-like labels
+        with self.assertRaises(ValueError):
+            self.array.append_set_dimension('Sample 1')
+        with self.assertRaises(ValueError):
+            self.array.append_set_dimension(1000)
 
-    def test_set_dim_labels_single_float(self):
-        labels = 1000
-        setdim = self.array.append_set_dimension(labels)
-        assert tuple([str(labels)]) == setdim.labels
+        # don't accept list of non-string objects
+        with self.assertRaises(ValueError):
+            self.array.append_set_dimension([1, 2, 3])
 
     def test_range_dim_ticks_resize(self):
         rangedim = self.array.append_range_dimension([1, 2, 100])