Skip to content

Commit 45d2b98

Browse files
committed
[property] Add Value 0 as Int
Allow value = 0 set as int, not as empty value. Fixing issue #314.
1 parent 9915a72 commit 45d2b98

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

odml/property.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def __init__(self, name=None, values=None, parent=None, unit=None,
8282

8383
self._values = []
8484
self.values = values
85-
if not values and (value or isinstance(value, bool)):
85+
if not values and (value or isinstance(value, bool) or isinstance(value, int)):
8686
self.values = value
8787

8888
self.parent = parent

test/test_property.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,10 @@ def test_value_append(self):
183183
self.assertEqual(len(p5), 2)
184184
self.assertRaises(ValueError, p5.append, "[a, b, c]")
185185

186+
p6 = Property('myprop', value=0, dtype=DType.int)
187+
self.assertEqual(p6.value, [0])
188+
self.assertEqual(p6.values, [0])
189+
186190
def test_value_extend(self):
187191
prop = Property(name="extend")
188192

0 commit comments

Comments
 (0)