Skip to content

Commit 73e230e

Browse files
committed
[Property] Use 'values' instead of 'value'
1 parent 13d1f64 commit 73e230e

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

odml/property.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def __init__(self, name=None, value=None, parent=None, unit=None,
7979
print("Warning: Unknown dtype '%s'." % dtype)
8080

8181
self._values = []
82-
self.value = value
82+
self.values = value
8383

8484
self.parent = parent
8585

@@ -169,7 +169,7 @@ def dtype(self, new_type):
169169
old_values = self._values
170170
try:
171171
self._dtype = new_type
172-
self.value = old_values
172+
self.values = old_values
173173
except:
174174
self._dtype = old_type # If conversion failed, restore old dtype
175175
raise ValueError("cannot convert from '%s' to '%s'" %
@@ -435,7 +435,7 @@ def clone(self, keep_id=False):
435435
"""
436436
obj = super(BaseProperty, self).clone()
437437
obj._parent = None
438-
obj.value = self._values
438+
obj.values = self._values
439439
if not keep_id:
440440
obj.new_id()
441441

@@ -459,7 +459,7 @@ def merge_check(self, source, strict=True):
459459

460460
# Catch unmerge-able values at this point to avoid
461461
# failing Section tree merges which cannot easily be rolled back.
462-
new_value = self._convert_value_input(source.value)
462+
new_value = self._convert_value_input(source.values)
463463
if not self._validate_values(new_value):
464464
raise ValueError("odml.Property.merge: passed value(s) cannot "
465465
"be converted to data type '%s'!" % self._dtype)
@@ -530,7 +530,7 @@ def merge(self, other, strict=True):
530530
if self.unit is None and other.unit is not None:
531531
self.unit = other.unit
532532

533-
to_add = [v for v in other.value if v not in self._values]
533+
to_add = [v for v in other.values if v not in self._values]
534534
self.extend(to_add, strict=strict)
535535

536536
def unmerge(self, other):
@@ -575,11 +575,11 @@ def extend(self, obj, strict=True):
575575
if obj.unit != self.unit:
576576
raise ValueError("odml.Property.extend: src and dest units (%s, %s) "
577577
"do not match!" % (obj.unit, self.unit))
578-
self.extend(obj.value)
578+
self.extend(obj.values)
579579
return
580580

581581
if self.__len__() == 0:
582-
self.value = obj
582+
self.values = obj
583583
return
584584

585585
new_value = self._convert_value_input(obj)
@@ -605,8 +605,8 @@ def append(self, obj, strict=True):
605605
if obj in [None, "", [], {}]:
606606
return
607607

608-
if not self.value:
609-
self.value = obj
608+
if not self.values:
609+
self.values = obj
610610
return
611611

612612
new_value = self._convert_value_input(obj)

0 commit comments

Comments
 (0)