Skip to content

Commit c7a7db7

Browse files
committed
[property] Add validation on values set
1 parent 8a49b32 commit c7a7db7

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

odml/property.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ def __init__(self, name=None, values=None, parent=None, unit=None,
119119
self._definition = definition
120120
self._dependency = dependency
121121
self._dependency_value = dependency_value
122+
self._val_cardinality = None
122123

123124
self._dtype = None
124125
if dtypes.valid_type(dtype):
@@ -135,7 +136,6 @@ def __init__(self, name=None, values=None, parent=None, unit=None,
135136

136137
# Cardinality should always be set after values have been added
137138
# since it is always tested against values when it is set.
138-
self._val_cardinality = None
139139
self.val_cardinality = val_cardinality
140140

141141
for err in validation.Validation(self).errors:
@@ -410,6 +410,11 @@ def values(self, new_value):
410410
raise ValueError(msg)
411411
self._values = [dtypes.get(v, self.dtype) for v in new_value]
412412

413+
# Validate and inform user if the current values cardinality is violated
414+
valid = validation.Validation(self)
415+
for err in valid.errors:
416+
print("%s: %s" % (err.rank.capitalize(), err.msg))
417+
413418
@property
414419
def value_origin(self):
415420
"""

0 commit comments

Comments
 (0)