Skip to content

Commit f70929d

Browse files
committed
Remove py2 assertRegexpMatches usage
1 parent e2baec1 commit f70929d

File tree

1 file changed

+6
-20
lines changed

1 file changed

+6
-20
lines changed

test/test_dtypes.py

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,11 @@
11
import datetime
22
import unittest
33

4-
from sys import version_info
5-
64
import odml.dtypes as typ
75

86

97
class TestTypes(unittest.TestCase):
108

11-
def assert_local_regexp(self, text, regular_expression):
12-
"""
13-
Python 2 is dead and assertRegexpMatches is deprecated and
14-
will be removed, but keep compatibility until py 2 support is
15-
fully dropped.
16-
"""
17-
18-
if version_info.major < 3:
19-
self.assertRegexpMatches(text, regular_expression)
20-
else:
21-
self.assertRegex(text, regular_expression)
22-
239
def test_valid_type(self):
2410
# Test None
2511
self.assertTrue(typ.valid_type(None))
@@ -47,8 +33,8 @@ def test_date(self):
4733
self.assertIsInstance(typ.date_get(""), datetime.date)
4834

4935
reg = "^[0-9]{4}-(0[1-9]|1[0-2])-([0-2][0-9]|3[0-1])$"
50-
self.assert_local_regexp(typ.date_get(None).strftime(typ.FORMAT_DATE), reg)
51-
self.assert_local_regexp(typ.date_get("").strftime(typ.FORMAT_DATE), reg)
36+
self.assertRegex(typ.date_get(None).strftime(typ.FORMAT_DATE), reg)
37+
self.assertRegex(typ.date_get("").strftime(typ.FORMAT_DATE), reg)
5238

5339
date = datetime.date(2011, 12, 1)
5440
date_string = '2011-12-01'
@@ -79,8 +65,8 @@ def test_time(self):
7965
self.assertIsInstance(typ.time_get(""), datetime.time)
8066

8167
reg = "^[0-5][0-9]:[0-5][0-9]:[0-5][0-9]$"
82-
self.assert_local_regexp(typ.time_get(None).strftime(typ.FORMAT_TIME), reg)
83-
self.assert_local_regexp(typ.time_get("").strftime(typ.FORMAT_TIME), reg)
68+
self.assertRegex(typ.time_get(None).strftime(typ.FORMAT_TIME), reg)
69+
self.assertRegex(typ.time_get("").strftime(typ.FORMAT_TIME), reg)
8470

8571
time = datetime.time(12, 34, 56)
8672
time_string = '12:34:56'
@@ -111,8 +97,8 @@ def test_datetime(self):
11197
self.assertIsInstance(typ.datetime_get(""), datetime.datetime)
11298

11399
reg = "^[0-9]{4}-(0[1-9]|1[0-2])-([0-2][0-9]|3[0-1]) [0-5][0-9]:[0-5][0-9]:[0-5][0-9]$"
114-
self.assert_local_regexp(typ.datetime_get(None).strftime(typ.FORMAT_DATETIME), reg)
115-
self.assert_local_regexp(typ.datetime_get("").strftime(typ.FORMAT_DATETIME), reg)
100+
self.assertRegex(typ.datetime_get(None).strftime(typ.FORMAT_DATETIME), reg)
101+
self.assertRegex(typ.datetime_get("").strftime(typ.FORMAT_DATETIME), reg)
116102

117103
date = datetime.datetime(2011, 12, 1, 12, 34, 56)
118104
date_string = '2011-12-01 12:34:56'

0 commit comments

Comments
 (0)