test: use t.Fatalf for unexpected errors

G-Rath · G-Rath · commit 4a5aa66a03fe · 2025-09-03T08:20:22.000+12:00
diff --git a/pkg/database/api-check_test.go b/pkg/database/api-check_test.go
@@ -104,7 +104,7 @@ func TestAPIDB_Check_NoPackages(t *testing.T) {
 	vulns, err := db.Check([]internal.PackageDetails{})
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if len(vulns) > 0 {
@@ -297,7 +297,7 @@ func TestAPIDB_Check_FetchSuccessful(t *testing.T) {
 	})
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if len(vulns) != 1 {
@@ -353,7 +353,7 @@ func TestAPIDB_Check_FetchFails(t *testing.T) {
 	})
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if len(vulns) != 1 {
@@ -410,7 +410,7 @@ func TestAPIDB_Check_FetchMixed(t *testing.T) {
 	})
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if len(vulns) != 1 {
@@ -452,7 +452,7 @@ func TestAPIDB_Check_WithCommit(t *testing.T) {
 	})
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if len(vulns) != 1 {
@@ -524,7 +524,7 @@ func TestAPIDB_Check_Batches(t *testing.T) {
 	})
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if requestCount != 2 {
diff --git a/pkg/database/api_test.go b/pkg/database/api_test.go
@@ -74,14 +74,11 @@ func TestNewAPIDB_Valid(t *testing.T) {
 	)
 
 	if err != nil {
-		t.Errorf("NewAPIDB() unexpected error \"%v\"", err)
+		t.Fatalf("NewAPIDB() unexpected error \"%v\"", err)
 	}
 
 	if db == nil {
 		t.Fatalf("NewAPIDB() db unexpectedly nil")
-
-		// this is required currently to make the staticcheck linter
-		return
 	}
 
 	if !reflect.DeepEqual(db.BaseURL, u) {
diff --git a/pkg/database/dir_test.go b/pkg/database/dir_test.go
@@ -25,7 +25,7 @@ func TestNewDirDB(t *testing.T) {
 	db, err := database.NewDirDB(database.Config{URL: "file:/testdata/db"}, false)
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	expectDBToHaveOSVs(t, db, osvs)
@@ -85,7 +85,7 @@ func TestNewDirDB_WorkingDirectory(t *testing.T) {
 	db, err := database.NewDirDB(database.Config{URL: "file:/testdata/db", WorkingDirectory: "nested-1"}, false)
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	expectDBToHaveOSVs(t, db, osvs)
diff --git a/pkg/database/zip_test.go b/pkg/database/zip_test.go
@@ -75,7 +75,7 @@ func cacheWrite(t *testing.T, cache database.Cache) {
 	}
 
 	if err != nil {
-		t.Errorf("unexpected error with cache: %v", err)
+		t.Fatalf("unexpected error with cache: %v", err)
 	}
 }
 
@@ -86,7 +86,7 @@ func cacheWriteBad(t *testing.T, url string, contents string) {
 	err := os.WriteFile(cachePath(url), []byte(contents), 0644)
 
 	if err != nil {
-		t.Errorf("unexpected error with cache: %v", err)
+		t.Fatalf("unexpected error with cache: %v", err)
 	}
 }
 
@@ -179,7 +179,7 @@ func TestNewZippedDB_Offline_WithCache(t *testing.T) {
 	db, err := database.NewZippedDB(database.Config{URL: ts.URL}, true)
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	if db.UpdatedAt != date {
@@ -237,7 +237,7 @@ func TestNewZippedDB_Online_WithoutCache(t *testing.T) {
 	db, err := database.NewZippedDB(database.Config{URL: ts.URL}, false)
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	expectDBToHaveOSVs(t, db, osvs)
@@ -399,7 +399,7 @@ func TestNewZippedDB_FileChecks(t *testing.T) {
 	db, err := database.NewZippedDB(database.Config{URL: ts.URL}, false)
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	expectDBToHaveOSVs(t, db, osvs)
@@ -421,7 +421,7 @@ func TestNewZippedDB_WorkingDirectory(t *testing.T) {
 	db, err := database.NewZippedDB(database.Config{URL: ts.URL, WorkingDirectory: "reviewed"}, false)
 
 	if err != nil {
-		t.Errorf("unexpected error \"%v\"", err)
+		t.Fatalf("unexpected error \"%v\"", err)
 	}
 
 	expectDBToHaveOSVs(t, db, osvs)

Original file line number	Diff line number	Diff line change
`@@ -74,14 +74,11 @@ func TestNewAPIDB_Valid(t *testing.T) {`
`74`	`74`	`)`
`75`	`75`
`76`	`76`	`if err != nil {`
`77`		`- t.Errorf("NewAPIDB() unexpected error \"%v\"", err)`
	`77`	`+ t.Fatalf("NewAPIDB() unexpected error \"%v\"", err)`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`if db == nil {`
`81`	`81`	`t.Fatalf("NewAPIDB() db unexpectedly nil")`
`82`		`-`
`83`		`- // this is required currently to make the staticcheck linter`
`84`		`- return`
`85`	`82`	`}`
`86`	`83`
`87`	`84`	`if !reflect.DeepEqual(db.BaseURL, u) {`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ func TestNewDirDB(t *testing.T) {`
`25`	`25`	`db, err := database.NewDirDB(database.Config{URL: "file:/testdata/db"}, false)`
`26`	`26`
`27`	`27`	`if err != nil {`
`28`		`- t.Errorf("unexpected error \"%v\"", err)`
	`28`	`+ t.Fatalf("unexpected error \"%v\"", err)`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`expectDBToHaveOSVs(t, db, osvs)`
`@@ -85,7 +85,7 @@ func TestNewDirDB_WorkingDirectory(t *testing.T) {`
`85`	`85`	`db, err := database.NewDirDB(database.Config{URL: "file:/testdata/db", WorkingDirectory: "nested-1"}, false)`
`86`	`86`
`87`	`87`	`if err != nil {`
`88`		`- t.Errorf("unexpected error \"%v\"", err)`
	`88`	`+ t.Fatalf("unexpected error \"%v\"", err)`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`expectDBToHaveOSVs(t, db, osvs)`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func cacheWrite(t *testing.T, cache database.Cache) {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`if err != nil {`
`78`		`- t.Errorf("unexpected error with cache: %v", err)`
	`78`	`+ t.Fatalf("unexpected error with cache: %v", err)`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`
`@@ -86,7 +86,7 @@ func cacheWriteBad(t *testing.T, url string, contents string) {`
`86`	`86`	`err := os.WriteFile(cachePath(url), []byte(contents), 0644)`
`87`	`87`
`88`	`88`	`if err != nil {`
`89`		`- t.Errorf("unexpected error with cache: %v", err)`
	`89`	`+ t.Fatalf("unexpected error with cache: %v", err)`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`
`@@ -179,7 +179,7 @@ func TestNewZippedDB_Offline_WithCache(t *testing.T) {`
`179`	`179`	`db, err := database.NewZippedDB(database.Config{URL: ts.URL}, true)`
`180`	`180`
`181`	`181`	`if err != nil {`
`182`		`- t.Errorf("unexpected error \"%v\"", err)`
	`182`	`+ t.Fatalf("unexpected error \"%v\"", err)`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`if db.UpdatedAt != date {`
`@@ -237,7 +237,7 @@ func TestNewZippedDB_Online_WithoutCache(t *testing.T) {`
`237`	`237`	`db, err := database.NewZippedDB(database.Config{URL: ts.URL}, false)`
`238`	`238`
`239`	`239`	`if err != nil {`
`240`		`- t.Errorf("unexpected error \"%v\"", err)`
	`240`	`+ t.Fatalf("unexpected error \"%v\"", err)`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`expectDBToHaveOSVs(t, db, osvs)`
`@@ -399,7 +399,7 @@ func TestNewZippedDB_FileChecks(t *testing.T) {`
`399`	`399`	`db, err := database.NewZippedDB(database.Config{URL: ts.URL}, false)`
`400`	`400`
`401`	`401`	`if err != nil {`
`402`		`- t.Errorf("unexpected error \"%v\"", err)`
	`402`	`+ t.Fatalf("unexpected error \"%v\"", err)`
`403`	`403`	`}`
`404`	`404`
`405`	`405`	`expectDBToHaveOSVs(t, db, osvs)`
`@@ -421,7 +421,7 @@ func TestNewZippedDB_WorkingDirectory(t *testing.T) {`
`421`	`421`	`db, err := database.NewZippedDB(database.Config{URL: ts.URL, WorkingDirectory: "reviewed"}, false)`
`422`	`422`
`423`	`423`	`if err != nil {`
`424`		`- t.Errorf("unexpected error \"%v\"", err)`
	`424`	`+ t.Fatalf("unexpected error \"%v\"", err)`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	`expectDBToHaveOSVs(t, db, osvs)`