refactor(semantic): optimize loop exit condition

Author: G-Rath

.golangci.yaml

@@ -34,10 +34,6 @@ linters:
             - pkg: regexp
               desc:
                 Use github.com/g-rath/osv-detector/internal/cachedregexp instead
-    staticcheck:
-      checks:
-        - all
-        - -QF1006 # lift into loop condition
   exclusions:
     generated: lax
     presets:

pkg/semantic/version-debian.go

@@ -77,11 +77,7 @@ func compareDebianVersions(a, b string) int {
 	var adp, bdp *big.Int
 
 	// based off: https://man7.org/linux/man-pages/man7/deb-version.7.html
-	for {
-		if a == "" && b == "" {
-			break
-		}
-
+	for a != "" || b != "" {
 		ap, a = splitDebianNonDigitPrefix(a)
 		bp, b = splitDebianNonDigitPrefix(b)