test: add cases

G-Rath · G-Rath · commit 9982d3771719 · 2025-12-03T10:13:30.000+13:00
diff --git a/__snapshots__/main_test.snap b/__snapshots__/main_test.snap
@@ -58,6 +58,44 @@ You must provide at least one path to either a lockfile or a directory containin
 
 ---
 
+[TestRun_APIError/#00 - 1]
+Loaded the following OSV databases:
+  api#http://127.0.0.1:42805 (using batches of 1000)
+  RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
+
+/tmp/TestRun_APIError#003124218549/001/Gemfile.lock: found 1 package
+  Using config at /tmp/TestRun_APIError#003124218549/001/.osv-detector.yml (0 ignores)
+  Using db api#http://127.0.0.1:42805 (using batches of 1000)
+  Using db RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
+
+  no known vulnerabilities found
+
+---
+
+[TestRun_APIError/#00 - 2]
+  an api error occurred while trying to check the packages listed in /tmp/TestRun_APIError#003124218549/001/Gemfile.lock: api returned unexpected status (POST http://127.0.0.1:42805/querybatch 400)
+
+---
+
+[TestRun_APIError/#01 - 1]
+Loaded the following OSV databases:
+  api#http://127.0.0.1:36893 (using batches of 1000)
+  RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
+
+/tmp/TestRun_APIError#01238228472/001/Gemfile.lock: found 1 package
+  Using config at /tmp/TestRun_APIError#01238228472/001/.osv-detector.yml (0 ignores)
+  Using db api#http://127.0.0.1:36893 (using batches of 1000)
+  Using db RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
+
+  no known vulnerabilities found
+
+---
+
+[TestRun_APIError/#01 - 2]
+  an api error occurred while trying to check the packages listed in /tmp/TestRun_APIError#01238228472/001/Gemfile.lock: api response could not be parsed as json (POST http://127.0.0.1:36893/querybatch): invalid character '<' looking for beginning of value
+
+---
+
 [TestRun_Configs/#00 - 1]
 Loaded the following OSV databases:
 
diff --git a/main_test.go b/main_test.go
@@ -3,6 +3,8 @@ package main
 import (
 	"bytes"
 	"fmt"
+	"net/http"
+	"net/http/httptest"
 	"os"
 	"path/filepath"
 	"strings"
@@ -836,3 +838,63 @@ func TestRun_EndToEnd(t *testing.T) {
 		})
 	}
 }
+
+func TestRun_APIError(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct{ handler http.HandlerFunc }{
+		{
+			handler: func(w http.ResponseWriter, _ *http.Request) {
+				w.WriteHeader(http.StatusBadRequest)
+				_, _ = w.Write([]byte("{}"))
+			},
+		},
+		{
+			handler: func(w http.ResponseWriter, _ *http.Request) {
+				_, _ = w.Write([]byte("<html></html>"))
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run("", func(t *testing.T) {
+			t.Parallel()
+
+			tmp := t.TempDir()
+
+			var err error
+
+			// create a file for scanning
+			err = os.WriteFile(filepath.Join(tmp, "Gemfile.lock"), []byte(`
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.2)
+`), 0600)
+
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			// setup a fake api server
+			ts := httptest.NewServer(tt.handler)
+			t.Cleanup(ts.Close)
+
+			// create a config file setting up our api server
+			err = os.WriteFile(filepath.Join(tmp, ".osv-detector.yml"), []byte(`
+extra-databases:
+  - url: `+ts.URL,
+			), 0600)
+
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			// run the cli in our tmp directory
+			testCli(t, cliTestCase{
+				name: "",
+				args: []string{tmp},
+				exit: 127,
+			})
+		})
+	}
+}
