Skip to content

Commit 09b226b

Browse files
authored
Merge pull request finos#1359 from finos/fix/e2e-wf
fix: trigger for e2e tests
2 parents 718f961 + 25752fd commit 09b226b

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,10 @@ on:
1414
jobs:
1515
e2e:
1616
runs-on: ubuntu-latest
17-
# Only run on workflow_dispatch (manual trigger), but always register check on PRs
18-
if: github.event_name == 'workflow_dispatch'
1917

2018
steps:
2119
- name: Checkout code
2220
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4
23-
with:
24-
# When triggered by comment, checkout the PR branch
25-
ref: ${{ github.event_name == 'issue_comment' && format('refs/pull/{0}/head', github.event.issue.number) || github.ref }}
2621

2722
- name: Set up Docker Buildx
2823
uses: docker/setup-buildx-action@e468171a9de216ec08956ac3ada2f0791b6bd435
@@ -50,8 +45,11 @@ jobs:
5045

5146
- name: Wait for services to be ready
5247
run: |
53-
timeout 60 bash -c 'until docker compose ps | grep -q "Up"; do sleep 2; done'
54-
sleep 10
48+
timeout 60 bash -c '
49+
while [ "$(docker compose ps | grep -c "Up")" -ne 3 ]; do
50+
sleep 2
51+
done
52+
' || { echo "Service readiness check failed:"; docker compose ps; exit 1; }
5553
5654
- name: Run E2E tests
5755
run: npm run test:e2e

0 commit comments

Comments
 (0)