refactor: make Proxy.stop() await all server shutdowns in parallel

Author: fabiovincenzi

src/proxy/index.ts

@@ -101,35 +101,51 @@ export class Proxy {
   }
 
   public stop(): Promise<void> {
-    return new Promise((resolve, reject) => {
-      try {
-        // Close HTTP server if it exists
-        if (this.httpServer) {
-          this.httpServer.close(() => {
-            console.log('HTTP server closed');
-            this.httpServer = null;
+    const closePromises: Promise<void>[] = [];
+
+    // Close HTTP server if it exists
+    if (this.httpServer) {
+      closePromises.push(
+        new Promise((resolve, reject) => {
+          this.httpServer!.close((err) => {
+            if (err) {
+              reject(err);
+            } else {
+              console.log('HTTP server closed');
+              this.httpServer = null;
+              resolve();
+            }
           });
-        }
+        }),
+      );
+    }
 
-        // Close HTTPS server if it exists
-        if (this.httpsServer) {
-          this.httpsServer.close(() => {
-            console.log('HTTPS server closed');
-            this.httpsServer = null;
+    // Close HTTPS server if it exists
+    if (this.httpsServer) {
+      closePromises.push(
+        new Promise((resolve, reject) => {
+          this.httpsServer!.close((err) => {
+            if (err) {
+              reject(err);
+            } else {
+              console.log('HTTPS server closed');
+              this.httpsServer = null;
+              resolve();
+            }
           });
-        }
+        }),
+      );
+    }
 
-        // Close SSH server if it exists
-        if (this.sshServer) {
-          this.sshServer.stop();
-          console.log('SSH server stopped');
+    // Close SSH server if it exists
+    if (this.sshServer) {
+      closePromises.push(
+        this.sshServer.stop().then(() => {
           this.sshServer = null;
-        }
+        }),
+      );
+    }
 
-        resolve();
-      } catch (error) {
-        reject(error);
-      }
-    });
+    return Promise.all(closePromises).then(() => {});
   }
 }

src/proxy/ssh/server.ts

@@ -646,12 +646,17 @@ export class SSHServer {
     });
   }
 
-  public stop(): void {
-    if (this.server) {
-      this.server.close(() => {
-        console.log('[SSH] Server stopped');
-      });
-    }
+  public stop(): Promise<void> {
+    return new Promise((resolve) => {
+      if (this.server) {
+        this.server.close(() => {
+          console.log('[SSH] Server stopped');
+          resolve();
+        });
+      } else {
+        resolve();
+      }
+    });
   }
 }