Skip to content

Commit 22fb1ef

Browse files
authored
Hotfix: use system-provided cyrus-sasl/libsasl2 at runtime (#7)
* CI: improve version management - make sure that only the specific version of librdkafka.redist can be restored - make sure that the tag and project versions match - handle versions with build metadata * Hotfix: use system-provided cyrus-sasl/libsasl2 at runtime * Bump version to 2.11.0.1-RC1+gr
1 parent 53b6382 commit 22fb1ef

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

.github/workflows/build.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ jobs:
2525
- name: Build and test
2626
run: |
2727
dotnet nuget add source --username user --password ${{ github.token }} --store-password-in-clear-text --name github https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json
28-
dotnet restore
29-
dotnet test -c Release test/Confluent.Kafka.UnitTests/Confluent.Kafka.UnitTests.csproj
28+
dotnet test -c Release /p:TreatWarningsAsErrors=true test/Confluent.Kafka.UnitTests/Confluent.Kafka.UnitTests.csproj
3029
3130
package:
3231
needs: [build-test]
@@ -50,17 +49,22 @@ jobs:
5049
- name: Build and create packages
5150
run: |
5251
dotnet nuget add source --username user --password ${{ github.token }} --store-password-in-clear-text --name github https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json
53-
dotnet restore
5452
dotnet build Confluent.Kafka.sln -c Release
5553
5654
# Different packaging for tagged vs untagged builds
55+
$proj_version = (dotnet msbuild ./src/Confluent.Kafka/Confluent.Kafka.csproj -getproperty:VersionPrefix)
5756
if ($env:GITHUB_REF -match '^refs/tags/') {
58-
$suffix = "gr"
57+
$tag_version = $env:GITHUB_REF -replace '^refs/tags/v', ''
58+
if ($tag_version -ne $proj_version) {
59+
Write-Output "::error title=Version mismatch::Tag version '$tag_version' does not match project version '$proj_version'."
60+
exit 1
61+
}
5962
} else {
60-
$suffix = "ci-$env:GITHUB_RUN_ID"
63+
$version_components = $proj_version -split '\+'
64+
$version_args = @("/p:Version=$($version_components[0])-ci-$env:GITHUB_RUN_ID+$($version_components[1])")
6165
}
6266
63-
dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj --output dist -c Release --version-suffix $suffix
67+
dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj --output dist -c Release @version_args
6468
6569
- name: Upload artifacts
6670
uses: actions/upload-artifact@v4

src/Confluent.Kafka/Confluent.Kafka.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<PackageReadmeFile>README.md</PackageReadmeFile>
1717
<Title>Confluent.Kafka</Title>
1818
<AssemblyName>Confluent.Kafka</AssemblyName>
19-
<VersionPrefix>2.11.0</VersionPrefix>
19+
<VersionPrefix>2.11.0.1-RC1+gr</VersionPrefix>
2020
<TargetFrameworks>netstandard2.0;net462;net6.0;net8.0</TargetFrameworks>
2121
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
2222
<GenerateDocumentationFile>true</GenerateDocumentationFile>
@@ -25,7 +25,7 @@
2525
</PropertyGroup>
2626

2727
<ItemGroup>
28-
<PackageReference Include="librdkafka.redist" Version="2.11.0-gr">
28+
<PackageReference Include="librdkafka.redist" Version="2.11.0.1-RC1+gr">
2929
<PrivateAssets Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">None</PrivateAssets>
3030
</PackageReference>
3131
</ItemGroup>

0 commit comments

Comments
 (0)