Skip to content

Commit cfa2bed

Browse files
Using try-with-resources to ensure closed streams
Signed-off-by: Decker, Stefan <[email protected]>
1 parent 44d82aa commit cfa2bed

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/main/java/de/gdata/mobilelab/alertmanagercallback/AlertManagerPostRequestSender.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,20 +65,19 @@ private String postForResponseAsString(String targetUrl, String payload) throws
6565
connection.setRequestProperty("Content-Type", "application/json;");
6666
connection.setRequestProperty("Accept", "application/json,text/plain");
6767
connection.setRequestProperty("Method", "POST");
68-
OutputStream os = connection.getOutputStream();
69-
os.write(payload.getBytes(StandardCharsets.UTF_8));
70-
os.close();
68+
try (OutputStream os = connection.getOutputStream()) {
69+
os.write(payload.getBytes(StandardCharsets.UTF_8));
70+
}
7171

7272
StringBuilder sb = new StringBuilder();
7373
int HttpResult = connection.getResponseCode();
7474
if (HttpResult == HttpURLConnection.HTTP_OK) {
75-
BufferedReader br = new BufferedReader(new InputStreamReader(connection.getInputStream(), StandardCharsets.UTF_8));
76-
77-
String line;
78-
while ((line = br.readLine()) != null) {
79-
sb.append(line).append("\n");
75+
try (BufferedReader br = new BufferedReader(new InputStreamReader(connection.getInputStream(), StandardCharsets.UTF_8))) {
76+
String line;
77+
while ((line = br.readLine()) != null) {
78+
sb.append(line).append("\n");
79+
}
8080
}
81-
br.close();
8281
connection.disconnect();
8382
return sb.toString();
8483
} else {

0 commit comments

Comments
 (0)