Merge pull request #36 from GDATASoftwareAG/fix-deref-empty-nic

Mattes83 · web-flow · commit 8151dd1770a9 · 2023-11-13T16:23:56.000+01:00
fix deref empty nic
diff --git a/internal/controller/ionoscloudmachine_controller.go b/internal/controller/ionoscloudmachine_controller.go
@@ -204,7 +204,7 @@ func (r *IONOSCloudMachineReconciler) reconcileDeleteLoadBalancerForwardingRule(
 	lbSpec := ctx.IONOSCloudCluster.Spec.LoadBalancer
 	nic := ctx.IONOSCloudMachine.NicByLan(lbSpec.TargetLanRef.Name)
 
-	if nic == nil && nic.PrimaryIP != nil {
+	if nic == nil || nic.PrimaryIP == nil {
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ func (r *IONOSCloudMachineReconciler) reconcileDeleteLoadBalancerForwardingRule(`
`204`	`204`	`lbSpec := ctx.IONOSCloudCluster.Spec.LoadBalancer`
`205`	`205`	`nic := ctx.IONOSCloudMachine.NicByLan(lbSpec.TargetLanRef.Name)`
`206`	`206`
`207`		`- if nic == nil && nic.PrimaryIP != nil {`
	`207`	`+ if nic == nil \|\| nic.PrimaryIP == nil {`
`208`	`208`	`return nil`
`209`	`209`	`}`
`210`	`210`