Use blocking filesystem driver during VaaS file upload (#273)

The asynchronous amphp file library may in certain setups spawn multiple
processes to avoid blocking file I/O. This is unsupported in some
hosting environments.

Starting with VaaS SDK 11.1.0 we can provide a custom amphp driver for
file I/O during upload (to override the default amphp driver selection).
Forcefully select the blocking implementation, which never uses multiple
processes.

Author: GermanCoding

composer.json

@@ -9,7 +9,7 @@
         }
     ],
     "require": {
-        "gdata/vaas": "11.0.1",
+        "gdata/vaas": "11.1.0",
         "coduo/php-humanizer": "5.0.0"
     },
     "require-dev": {

lib/Service/VerdictService.php

@@ -6,7 +6,8 @@
 
 namespace OCA\GDataVaas\Service;
 
-use Exception;
+use Amp\File\Driver\BlockingFilesystemDriver;
+use Amp\File\FilesystemDriver;
 use OC\User\NoUserException;
 use OCA\GDataVaas\AppInfo\Application;
 use OCP\Files\EntityTooLargeException;
@@ -19,6 +20,7 @@
 use VaasSdk\Exceptions\VaasAuthenticationException;
 use VaasSdk\Exceptions\VaasClientException;
 use VaasSdk\Exceptions\VaasServerException;
+use VaasSdk\Options\ForFileOptions;
 use VaasSdk\Options\VaasOptions;
 use VaasSdk\Vaas;
 use VaasSdk\VaasVerdict;
@@ -35,6 +37,7 @@ class VerdictService {
 	private FileService $fileService;
 	private TagService $tagService;
 	private ?Vaas $vaas = null;
+	private FilesystemDriver $filesystemDriver;
 	private LoggerInterface $logger;
 
 	public function __construct(
@@ -47,6 +50,7 @@ public function __construct(
 		$this->appConfig = $appConfig;
 		$this->fileService = $fileService;
 		$this->tagService = $tagService;
+		$this->filesystemDriver = new BlockingFilesystemDriver();
 
 		$this->authMethod = $this->appConfig->getValueString(
 			Application::APP_ID, 'authMethod', 'ClientCredentials'
@@ -186,7 +190,8 @@ public function scan(string $filePath): VaasVerdict {
 			$this->vaas = $this->createAndConnectVaas();
 		}
 
-		return $this->vaas->forFileAsync($filePath)->await();
+		$options = new ForFileOptions(true, true, ForFileOptions::DEFAULT_TIMEOUT, $this->filesystemDriver);
+		return $this->vaas->forFileAsync($filePath, $options)->await();
 	}
 
 	/**