Skip to content

Commit d37e005

Browse files
committed
Lines < 120 chars
1 parent 329b7a2 commit d37e005

File tree

2 files changed

+61
-8
lines changed

2 files changed

+61
-8
lines changed

tests/integration/BaseIntegrationTest.php

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,13 @@ protected function uploadFileFromDisk(string $username, string $password, string
182182
]);
183183
}
184184

185-
protected function testGetEndpoint(string $endpoint, string $description, int $expectedHttpStatus = 200, string $username = 'admin', string $password = 'admin'): void {
185+
protected function testGetEndpoint(
186+
string $endpoint,
187+
string $description,
188+
int $expectedHttpStatus = 200,
189+
string $username = 'admin',
190+
string $password = 'admin'
191+
): void {
186192
$url = "http://{$this->hostname}/apps/gdatavaas/{$endpoint}";
187193

188194
$result = $this->makeHttpRequest('GET', $url, [
@@ -192,7 +198,14 @@ protected function testGetEndpoint(string $endpoint, string $description, int $e
192198
$this->assertEquals($expectedHttpStatus, $result['http_code'], "Failed: {$description}");
193199
}
194200

195-
protected function testPostEndpoint(string $endpoint, array $data, string $description, int $expectedHttpStatus = 200, string $username = 'admin', string $password = 'admin'): void {
201+
protected function testPostEndpoint(
202+
string $endpoint,
203+
array $data,
204+
string $description,
205+
int $expectedHttpStatus = 200,
206+
string $username = 'admin',
207+
string $password = 'admin'
208+
): void {
196209
$url = "http://{$this->hostname}/apps/gdatavaas/{$endpoint}";
197210

198211
$result = $this->makeHttpRequest('POST', $url, [

tests/integration/SettingsControllerTest.php

Lines changed: 46 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,23 +86,49 @@ public function testAdminCanAccessOperatorPostRoutes(string $route, array $data)
8686

8787
#[DataProvider('adminGetRouteProvider')]
8888
public function testOperatorCannotAccessAdminGetRoutes(string $route): void {
89-
$this->testGetEndpoint($route, "Operator access to {$route}", 403, username: 'vaas-operator', password: 'gdatavaas-operator');
89+
$this->testGetEndpoint(
90+
$route,
91+
"Operator access to {$route}",
92+
403,
93+
username: 'vaas-operator',
94+
password: 'gdatavaas-operator'
95+
);
9096
}
9197

9298

9399
#[DataProvider('adminPostRouteProvider')]
94100
public function testOperatorCannotAccessAdminPostRoutes(string $route, array $data): void {
95-
$this->testPostEndpoint($route, $data, "Operator access to {$route}", 403, username: 'vaas-operator', password: 'gdatavaas-operator');
101+
$this->testPostEndpoint(
102+
$route,
103+
$data,
104+
"Operator access to {$route}",
105+
403,
106+
username: 'vaas-operator',
107+
password: 'gdatavaas-operator'
108+
);
96109
}
97110

98111
#[DataProvider('operatorGetRouteProvider')]
99112
public function testOperatorCanAccessOperatorGetRoutes(string $route): void {
100-
$this->testGetEndpoint($route, "Operator access to {$route}", 200, username: 'vaas-operator', password: 'gdatavaas-operator');
113+
$this->testGetEndpoint(
114+
$route,
115+
"Operator access to {$route}",
116+
200,
117+
username: 'vaas-operator',
118+
password: 'gdatavaas-operator'
119+
);
101120
}
102121

103122
#[DataProvider('operatorPostRouteProvider')]
104123
public function testOperatorCanAccessOperatorPostRoutes(string $route, array $data): void {
105-
$this->testPostEndpoint($route, $data, "Operator access to {$route}", 200, username: 'vaas-operator', password: 'gdatavaas-operator');
124+
$this->testPostEndpoint(
125+
$route,
126+
$data,
127+
"Operator access to {$route}",
128+
200,
129+
username: 'vaas-operator',
130+
password: 'gdatavaas-operator'
131+
);
106132
}
107133

108134

@@ -114,7 +140,14 @@ public function testUserCannotAccessAdminGetRoutes(string $route): void {
114140

115141
#[DataProvider('adminPostRouteProvider')]
116142
public function testUserCannotAccessAdminPostRoutes(string $route, array $data): void {
117-
$this->testPostEndpoint($route, $data, "Operator access to {$route}", 403, username: 'user', password: 'gdatavaas-user');
143+
$this->testPostEndpoint(
144+
$route,
145+
$data,
146+
"Operator access to {$route}",
147+
403,
148+
username: 'user',
149+
password: 'gdatavaas-user'
150+
);
118151
}
119152

120153
#[DataProvider('operatorGetRouteProvider')]
@@ -124,7 +157,14 @@ public function testUserCannotAccessOperatorGetRoutes(string $route): void {
124157

125158
#[DataProvider('operatorPostRouteProvider')]
126159
public function testUserCannotAccessOperatorPostRoutes(string $route, array $data): void {
127-
$this->testPostEndpoint($route, $data, "Operator access to {$route}", 403, username: 'user', password: 'gdatavaas-user');
160+
$this->testPostEndpoint(
161+
$route,
162+
$data,
163+
"Operator access to {$route}",
164+
403,
165+
username: 'user',
166+
password: 'gdatavaas-user'
167+
);
128168
}
129169

130170

0 commit comments

Comments
 (0)