VmiCore: code reformat

Dorian Eikenberg · Dorian Eikenberg · commit 3f9bc7f8ce73 · 2025-05-06T11:30:28.000+02:00
diff --git a/.github/workflows/cpp-apitracing.yml b/.github/workflows/cpp-apitracing.yml
@@ -33,7 +33,7 @@ jobs:
   format:
     runs-on: ubuntu-latest
     container:
-      image: gdatacyberdefense/clang-format:16
+      image: gdatacyberdefense/clang-format:19
 
     steps:
       - uses: actions/checkout@v4
diff --git a/.github/workflows/cpp-core.yml b/.github/workflows/cpp-core.yml
@@ -29,7 +29,7 @@ jobs:
   format:
     runs-on: ubuntu-latest
     container:
-      image: gdatacyberdefense/clang-format:16
+      image: gdatacyberdefense/clang-format:19
 
     steps:
       - uses: actions/checkout@v4
diff --git a/.github/workflows/cpp-inmemory.yml b/.github/workflows/cpp-inmemory.yml
@@ -33,7 +33,7 @@ jobs:
   format:
     runs-on: ubuntu-latest
     container:
-      image: gdatacyberdefense/clang-format:16
+      image: gdatacyberdefense/clang-format:19
 
     steps:
       - uses: actions/checkout@v4
diff --git a/.github/workflows/cpp-template.yml b/.github/workflows/cpp-template.yml
@@ -33,7 +33,7 @@ jobs:
   format:
     runs-on: ubuntu-latest
     container:
-      image: gdatacyberdefense/clang-format:16
+      image: gdatacyberdefense/clang-format:19
 
     steps:
       - uses: actions/checkout@v4
diff --git a/vmicore/src/Cmdline.cpp b/vmicore/src/Cmdline.cpp
@@ -4,7 +4,6 @@
 
 std::istream& operator>>(std::istream& is, std::pair<std::string, std::string>& p)
 {
-
     std::string paramValue;
     std::getline(is, paramValue, {});
     auto index = paramValue.find(':');
diff --git a/vmicore/src/lib/VmiHub.cpp b/vmicore/src/lib/VmiHub.cpp
@@ -108,9 +108,7 @@ namespace VmiCore
 
     void setupSignalHandling()
     {
-        struct sigaction sigactionStruct
-        {
-        };
+        struct sigaction sigactionStruct{};
         sigactionStruct.sa_handler = &externalInterruptHandler;
         auto status = sigaction(SIGINT, &sigactionStruct, nullptr);
         if (status != 0)
diff --git a/vmicore/src/lib/vmi/Breakpoint.cpp b/vmicore/src/lib/vmi/Breakpoint.cpp
@@ -47,6 +47,7 @@ namespace VmiCore
                 fmt::format("{}: {} Target physical address = {:#x}", __func__, e.what(), targetPA));
         }
     }
+
     BPStateResponse Breakpoint::getNewBreakpointState(uint64_t newDtb) const
     {
         using enum VmiCore::BPStateResponse;
diff --git a/vmicore/src/lib/vmi/InterruptEventSupervisor.cpp b/vmicore/src/lib/vmi/InterruptEventSupervisor.cpp
@@ -9,7 +9,6 @@
 
 namespace VmiCore
 {
-
     namespace
     {
         InterruptEventSupervisor* interruptEventSupervisor = nullptr;
diff --git a/vmicore/src/lib/vmi/SingleStepSupervisor.cpp b/vmicore/src/lib/vmi/SingleStepSupervisor.cpp
@@ -97,9 +97,9 @@ namespace VmiCore
         vmiInterface->registerEvent(singleStepEvents[vcpuId]);
     }
 
-    event_response_t SingleStepSupervisor::_defaultSingleStepCallback(__attribute__((unused))
-                                                                      vmi_instance_t vmiInstance,
-                                                                      vmi_event_t* event)
+    event_response_t
+    SingleStepSupervisor::_defaultSingleStepCallback(__attribute__((unused)) vmi_instance_t vmiInstance,
+                                                     vmi_event_t* event)
     {
         auto eventResponse = VMI_EVENT_RESPONSE_NONE;
         try
diff --git a/vmicore/src/lib/vmi/VmiInitError.h b/vmicore/src/lib/vmi/VmiInitError.h
@@ -1,8 +1,8 @@
 #ifndef VMICORE_VMIINITERROR_H
 #define VMICORE_VMIINITERROR_H
 
-#include <vmicore/vmi/VmiException.h>
 #include <libvmi/events.h>
+#include <vmicore/vmi/VmiException.h>
 
 namespace VmiCore
 {
diff --git a/vmicore/test/lib/vmi/InterruptEventSupervisor_UnitTest.cpp b/vmicore/test/lib/vmi/InterruptEventSupervisor_UnitTest.cpp
@@ -3,8 +3,8 @@
 #include "../os/windows/mock_ActiveProcessesSupervisor.h"
 #include "mock_LibvmiInterface.h"
 #include "mock_SingleStepSupervisor.h"
-#include <gtest/gtest.h>
 #include <GlobalControl.h>
+#include <gtest/gtest.h>
 #include <plugins/PluginSystem.h>
 #include <vmicore/os/PagingDefinitions.h>
 #include <vmicore/vmi/IBreakpoint.h>
diff --git a/vmicore/test/lib/vmi/SingleStepSupervisor_UnitTest.cpp b/vmicore/test/lib/vmi/SingleStepSupervisor_UnitTest.cpp
@@ -1,8 +1,8 @@
 #include "../io/mock_EventStream.h"
 #include "../io/mock_Logging.h"
 #include "mock_LibvmiInterface.h"
-#include <gtest/gtest.h>
 #include <GlobalControl.h>
+#include <gtest/gtest.h>
 #include <vmi/SingleStepSupervisor.h>
 #include <vmicore/vmi/VmiException.h>
 #include <vmicore_test/io/mock_Logger.h>

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`
`5`	`5`	`std::istream& operator>>(std::istream& is, std::pair<std::string, std::string>& p)`
`6`	`6`	`{`
`7`		`-`
`8`	`7`	`std::string paramValue;`
`9`	`8`	`std::getline(is, paramValue, {});`
`10`	`9`	`auto index = paramValue.find(':');`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ namespace VmiCore`
`47`	`47`	`fmt::format("{}: {} Target physical address = {:#x}", __func__, e.what(), targetPA));`
`48`	`48`	`}`
`49`	`49`	`}`
	`50`	`+`
`50`	`51`	`BPStateResponse Breakpoint::getNewBreakpointState(uint64_t newDtb) const`
`51`	`52`	`{`
`52`	`53`	`using enum VmiCore::BPStateResponse;`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`
`10`	`10`	`namespace VmiCore`
`11`	`11`	`{`
`12`		`-`
`13`	`12`	`namespace`
`14`	`13`	`{`
`15`	`14`	`InterruptEventSupervisor* interruptEventSupervisor = nullptr;`
Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,9 @@ namespace VmiCore`
`97`	`97`	`vmiInterface->registerEvent(singleStepEvents[vcpuId]);`
`98`	`98`	`}`
`99`	`99`
`100`		`- event_response_t SingleStepSupervisor::_defaultSingleStepCallback(__attribute__((unused))`
`101`		`- vmi_instance_t vmiInstance,`
`102`		`- vmi_event_t* event)`
	`100`	`+ event_response_t`
	`101`	`+ SingleStepSupervisor::_defaultSingleStepCallback(__attribute__((unused)) vmi_instance_t vmiInstance,`
	`102`	`+ vmi_event_t* event)`
`103`	`103`	`{`
`104`	`104`	`auto eventResponse = VMI_EVENT_RESPONSE_NONE;`
`105`	`105`	`try`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`#ifndef VMICORE_VMIINITERROR_H`
`2`	`2`	`#define VMICORE_VMIINITERROR_H`
`3`	`3`
`4`		`-#include <vmicore/vmi/VmiException.h>`
`5`	`4`	`#include <libvmi/events.h>`
	`5`	`+#include <vmicore/vmi/VmiException.h>`
`6`	`6`
`7`	`7`	`namespace VmiCore`
`8`	`8`	`{`