Skip to content

Commit a89a5ac

Browse files
Merge pull request #515 from GDGAhmedabad/fix/team-partner-read-json
ref: Change Teams, Partners data source from generated to direct database JSON
2 parents e9023e7 + c6ff25a commit a89a5ac

File tree

2 files changed

+8
-85
lines changed

2 files changed

+8
-85
lines changed

src/elements/partners-block.ts

Lines changed: 4 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,10 @@
1-
import { Failure, Initialized, Pending, Success } from '@abraham/remotedata';
2-
import { computed, customElement, observe, property } from '@polymer/decorators';
1+
import { customElement } from '@polymer/decorators';
32
import '@polymer/iron-icon';
43
import '@polymer/paper-button';
54
import { html, PolymerElement } from '@polymer/polymer';
65
import '@power-elements/lazy-image';
7-
import { RootState, store } from '../store';
8-
import { closeDialog, openSubscribeDialog } from '../store/dialogs/actions';
6+
import { partners } from '../../public/data/firestore-data.json';
97
import { ReduxMixin } from '../store/mixin';
10-
import { PartnerGroupsState, selectPartnerGroups } from '../store/partners';
11-
import { addPotentialPartner } from '../store/potential-partners/actions';
12-
import {
13-
initialPotentialPartnersState,
14-
PotentialPartnersState,
15-
} from '../store/potential-partners/state';
16-
import { queueSnackbar } from '../store/snackbars';
178
import { loading, partnersBlock } from '../utils/data';
189
import '../utils/icons';
1910
import './shared-styles';
@@ -70,14 +61,7 @@ export class PartnersBlock extends ReduxMixin(PolymerElement) {
7061
<div class="container">
7162
<h1 class="container-title">[[partnersBlock.title]]</h1>
7263
73-
<template is="dom-if" if="[[pending]]">
74-
<p>[[loading]]</p>
75-
</template>
76-
<template is="dom-if" if="[[failure]]">
77-
<p>Error loading partners.</p>
78-
</template>
79-
80-
<template is="dom-repeat" items="[[partners.data]]" as="block">
64+
<template is="dom-repeat" items="[[partners]]" as="block">
8165
<h4 class="block-title">[[block.title]]</h4>
8266
<div class="logos-wrapper">
8367
<template is="dom-repeat" items="[[block.items]]" as="logo">
@@ -106,42 +90,5 @@ export class PartnersBlock extends ReduxMixin(PolymerElement) {
10690

10791
private loading = loading;
10892
private partnersBlock = partnersBlock;
109-
110-
@property({ type: Object })
111-
potentialPartners = initialPotentialPartnersState;
112-
@property({ type: Object })
113-
partners: PartnerGroupsState = new Initialized();
114-
115-
@computed('partners')
116-
get pending() {
117-
return this.partners instanceof Pending;
118-
}
119-
120-
@computed('partners')
121-
get failure() {
122-
return this.partners instanceof Failure;
123-
}
124-
125-
override stateChanged(state: RootState) {
126-
this.partners = selectPartnerGroups(state);
127-
this.potentialPartners = state.potentialPartners;
128-
}
129-
130-
private addPotentialPartner() {
131-
openSubscribeDialog({
132-
title: this.partnersBlock.form.title,
133-
submitLabel: this.partnersBlock.form.submitLabel,
134-
firstFieldLabel: this.partnersBlock.form.fullName,
135-
secondFieldLabel: this.partnersBlock.form.companyName,
136-
submit: (data) => store.dispatch(addPotentialPartner(data)),
137-
});
138-
}
139-
140-
@observe('potentialPartners')
141-
private onPotentialPartners(potentialPartners: PotentialPartnersState) {
142-
if (potentialPartners instanceof Success) {
143-
closeDialog();
144-
store.dispatch(queueSnackbar(this.partnersBlock.toast));
145-
}
146-
}
93+
private partners = partners;
14794
}

src/pages/team-page.ts

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
1-
import { Failure, Pending } from '@abraham/remotedata';
2-
import { computed, customElement, property } from '@polymer/decorators';
1+
import { customElement } from '@polymer/decorators';
32
import '@polymer/paper-icon-button';
43
import { html, PolymerElement } from '@polymer/polymer';
54
import '@power-elements/lazy-image';
5+
import { team as teams } from '../../public/data/firestore-data.json';
66
import '../components/hero/simple-hero';
77
import '../components/markdown/short-markdown';
88
import '../elements/shared-styles';
9-
import { RootState } from '../store';
109
import { ReduxMixin } from '../store/mixin';
11-
import { selectTeamsAndMembers } from '../store/teams-members/selectors';
12-
import { initialTeamsMembersState } from '../store/teams-members/state';
1310
import { heroSettings, loading, team } from '../utils/data';
1411
import { updateMetadata } from '../utils/metadata';
1512

@@ -137,15 +134,8 @@ export class TeamPage extends ReduxMixin(PolymerElement) {
137134
</div>
138135
139136
<div class="container">
140-
<template is="dom-if" if="[[pending]]">
141-
<p>[[loading]]</p>
142-
</template>
143-
144-
<template is="dom-if" if="[[failure]]">
145-
<p>Error loading teams.</p>
146-
</template>
147137
148-
<template is="dom-repeat" items="[[teamsMembers.data]]" as="team">
138+
<template is="dom-repeat" items="[[teams]]" as="team">
149139
<div class="team-title">[[team.title]]</div>
150140
151141
<div class="team-block">
@@ -184,25 +174,11 @@ export class TeamPage extends ReduxMixin(PolymerElement) {
184174
private heroSettings = heroSettings.team;
185175
private loading = loading;
186176
private team = team;
177+
private teams = teams;
187178

188-
@property({ type: Object })
189-
teamsMembers = initialTeamsMembersState;
190-
191-
@computed('teamsMembers')
192-
get pending() {
193-
return this.teamsMembers instanceof Pending;
194-
}
195-
196-
@computed('teamsMembers')
197-
get failure() {
198-
return this.teamsMembers instanceof Failure;
199-
}
200179
override connectedCallback() {
201180
super.connectedCallback();
202181
updateMetadata(this.heroSettings.title, this.heroSettings.metaDescription);
203182
}
204183

205-
override stateChanged(state: RootState) {
206-
this.teamsMembers = selectTeamsAndMembers(state);
207-
}
208184
}

0 commit comments

Comments
 (0)