[Reviewed] [3D particles] Fix the rotation around X axis to be the other way (#1724)

Author: D8H

extensions/reviewed/ParticleEmitter3D.json

@@ -9,7 +9,7 @@
   "name": "ParticleEmitter3D",
   "previewIconUrl": "https://asset-resources.gdevelop.io/public-resources/Icons/f2e5a34bf465f781866677762d385d6c8e9e8d203383f2df9a3b7e0fad6a2cb5_fire.svg",
   "shortDescription": "Display a large number of particles in 3D to create visual effects in a 3D game.",
-  "version": "2.2.0",
+  "version": "3.0.0",
   "description": [
     "3D particle emitters let you create and display many small particles to simulate visual effects in your game — like fire, explosions, smoke, or dust.",
     "",
@@ -34,6 +34,10 @@
     "IWykYNRvhCZBN3vEgKEbBPOR3Oc2"
   ],
   "changelog": [
+    {
+      "version": "3.0.0",
+      "breaking": "- the object rotates the other way around X axis."
+    },
     {
       "version": "2.0.0",
       "breaking": "- Object properties for position and rotation have been removed. They must be set with the instance editor or the action."
@@ -77,9 +81,7 @@
             "        const threeObject3D = this.get3DRendererObject();",
             "",
             "        threeObject3D.rotation.set(",
-            "            // TODO The rotation on X goes the wrong way.",
-            "            // Increment the major and remove this sign.",
-            "            - gdjs.toRad(this._object.getRotationX()),",
+            "            gdjs.toRad(this._object.getRotationX()),",
             "            gdjs.toRad(this._object.getRotationY()),",
             "            gdjs.toRad(this._object.angle)",
             "        );",
@@ -6993,6 +6995,15 @@
                 "",
                 "/** @type {gdjs.CustomRuntimeObject} */",
                 "const object = objects[0];",
+                "// Force the size of the object because it doesn't contain any instance.",
+                "object._innerArea = {",
+                "      min: [-16, -16, -16],",
+                "      max: [16, 16, 16],",
+                "    };",
+                "const hitbox = new gdjs.Polygon();",
+                "hitbox.vertices = [[-16, -16], [16, -16], [16, 16], [-16, 16]];",
+                "object._untransformedHitBoxes = [hitbox];",
+                "object._updateUntransformedHitBoxes = () => {};",
                 "",
                 "// Here runtimeScene is the gdjs.CustomRuntimeObjectInstanceContainer inside the custom object.",
                 "const gameScene = object.getRuntimeScene();",

scripts/lib/ExtensionsValidatorExceptions.js

@@ -390,6 +390,7 @@ const extensionsAllowedProperties = {
         'CustomRuntimeObject3DRenderer',
         'CustomRuntimeObject3D',
         'SpriteAnimationData',
+        'Polygon',
       ],
       gdjsEvtToolsAllowedProperties: [],
       runtimeSceneAllowedProperties: ['__particleEmmiter3DExtension'],