Skip to content

Commit 5ea2a5b

Browse files
committed
updated unit tests
1 parent 7ba2edb commit 5ea2a5b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/reactions/geochemistry/unitTests/testGeochemicalMixedReactions.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ TEST( testMixedReactions, testTimeStep_carbonateSystem )
3030

3131
double const expectedSpeciesConcentrations[numPrimarySpecies] =
3232
{
33-
2.5894448848121536e-05, // H+
34-
0.0062660162912796741, // HCO3-
35-
0.015741214773567921, // Ca+2
36-
0.0024602709470074127, // SO4-2
37-
1.8564927944498291, // Cl-
38-
0.0099316034080546619, // Mg+2
39-
1.0725251492409775 // Na+1
33+
9.671777755634228e-06, // H+
34+
0.016494147899655441, // HCO3-
35+
0.017327206801111415, // Ca+2
36+
0.0024137247729776557, // SO4-2
37+
1.8532341292597552, // Cl-
38+
0.010006970034001514, // Mg+2
39+
1.0728505565167725 // Na+1
4040
};
4141

4242
timeStepTest< double, true >( carbonateSystem,

src/reactions/reactionsSystems/KineticReactions_impl.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ KineticReactions< REAL_TYPE,
247247
for( IntType i = 0; i < PARAMS_DATA::numSpecies(); ++i )
248248
{
249249
RealType const s_ri = params.stoichiometricMatrix( r, i );
250-
reactionRatesDerivatives( r, i ) = rateConstant * surfaceArea[r] * s_ri * quotient / equilibriumConstant;
250+
reactionRatesDerivatives( r, i ) = - rateConstant * surfaceArea[r] * s_ri * quotient / equilibriumConstant;
251251
}
252252
} // end of if constexpr ( CALCULATE_DERIVATIVES )
253253
} // end of if constexpr ( LOGE_CONCENTRATION )
@@ -267,7 +267,7 @@ KineticReactions< REAL_TYPE,
267267
RealType const s_ri = params.stoichiometricMatrix( r, i );
268268
if( s_ri > 0.0 || s_ri < 0.0 )
269269
{
270-
reactionRatesDerivatives( r, i ) = rateConstant * surfaceArea[r] * s_ri * quotient / ( equilibriumConstant * speciesConcentration[i] );
270+
reactionRatesDerivatives( r, i ) = - rateConstant * surfaceArea[r] * s_ri * quotient / ( equilibriumConstant * speciesConcentration[i] );
271271
}
272272
else
273273
{
@@ -276,7 +276,7 @@ KineticReactions< REAL_TYPE,
276276
}
277277
} // end of if constexpr ( CALCULATE_DERIVATIVES )
278278
} // end of else
279-
reactionRates[r] = - rateConstant * surfaceArea[r] * ( 1.0 - quotient / equilibriumConstant );
279+
reactionRates[r] = rateConstant * surfaceArea[r] * ( 1.0 - quotient / equilibriumConstant );
280280
}
281281
}
282282

0 commit comments

Comments
 (0)