Skip to content

Commit 916438d

Browse files
committed
move stuff around to allow for separate geochem and battery chemistry approaches before we merge to a general form
1 parent 7d32702 commit 916438d

18 files changed

+7
-11
lines changed

src/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
set( hpcReact_headers
33
common/macros.hpp
44
common/CArrayWrapper.hpp
5-
reactions/EquilibriumReactions.hpp
6-
reactions/KineticReactions.hpp
7-
reactions/ReactionsBase.hpp
5+
reactions/geochemistry/EquilibriumReactions.hpp
6+
reactions/geochemistry/KineticReactions.hpp
7+
reactions/geochemistry/ReactionsBase.hpp
88
reactions/ReactionsParameterData.hpp
99
reactions/ReactionsParameterDataPredefined.hpp
1010
)
@@ -52,7 +52,7 @@ target_include_directories( hpcReact
5252
# hpcReact_add_code_checks( PREFIX hpcReact
5353
# EXCLUDES "blt/*" )
5454

55-
add_subdirectory( reactions/unitTests )
55+
add_subdirectory( reactions/geochemistry/unitTests )
5656

5757

5858
HPCReact_add_code_checks( PREFIX hpcReact
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/reactions/KineticReactions_impl.hpp renamed to src/reactions/geochemistry/KineticReactions_impl.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ KineticReactions< REAL_TYPE,
5252

5353
for( int iPri = 0; iPri < PARAMS_DATA::numPrimarySpecies; ++iPri )
5454
{
55-
saturationIndex += params.m_stoichMatrix[iRxn][iPri] * log10( primarySpeciesConcentration[iPri] );
56-
saturationIndex += params.m_stoichMatrix[iRxn][iPri] * log10PrimaryActCoeff[iPri];
55+
saturationIndex = saturationIndex
56+
+ params.m_stoichMatrix[iRxn][iPri] * log10( primarySpeciesConcentration[iPri] )
57+
+ params.m_stoichMatrix[iRxn][iPri] * log10PrimaryActCoeff[iPri];
5758
}
58-
5959
reactionRates[iRxn] = params.m_specificSurfaceArea * (1.0 - pow( 10, saturationIndex ) ) * params.m_reactionRateConstant[iRxn];
6060
}
6161
}
File renamed without changes.

src/reactions/ReactionsBase_impl.hpp renamed to src/reactions/geochemistry/ReactionsBase_impl.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ void ReactionsBase< REAL_TYPE,
3838
params.m_DebyeHuckelB /
3939
(1.0 + params.m_ionSizePrimary[i] * params.m_DebyeHuckelB * sqrt( ionicStrength )) /
4040
(1.0 + params.m_ionSizePrimary[i] * params.m_DebyeHuckelB * sqrt( ionicStrength )));
41-
// log10PrimaryActCoeff[i] = 0;
42-
// dLog10PrimaryActCoeff_dIonicStrength[i] = 0;
4341
}
4442
for( INDEX_TYPE i = 0; i < PARAMS_DATA::numSecondarySpecies; ++i )
4543
{
@@ -50,8 +48,6 @@ void ReactionsBase< REAL_TYPE,
5048
params.m_DebyeHuckelB /
5149
(1.0 + params.m_ionSizeSec[i] * params.m_DebyeHuckelB * sqrt( ionicStrength )) /
5250
(1.0 + params.m_ionSizeSec[i] * params.m_DebyeHuckelB * sqrt( ionicStrength )));
53-
// log10SecActCoeff[i] = 0;
54-
// dLog10SecActCoeff_dIonicStrength[i] = 0;
5551
}
5652
}
5753

File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)