Skip to content

Commit dc141c0

Browse files
committed
more derivatives
1 parent 9acef98 commit dc141c0

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/common/logMath.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ struct LogExp
3535
T dWrtLogConst()
3636
{
3737
if constexpr ( Base == LogBase::e ) { return T(1.0); }
38-
else { return T(ln10()); }
38+
else { return T(ln10<T>()); }
3939
}
4040

4141

src/reactions/massActions/MassActions.hpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,14 @@ void calculateAggregatePrimaryConcentrationsWrtLogC( PARAMS_DATA const & params,
147147
{
148148
REAL_TYPE const speciesConcentration_i = logmath::exp( logPrimarySpeciesConcentrations[i] );
149149
aggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i;
150-
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i;
150+
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst<REAL_TYPE>() * speciesConcentration_i;
151151
for( int j = 0; j < numSecondarySpecies; ++j )
152152
{
153153
REAL_TYPE const secondarySpeciesConcentrations_j = logmath::exp( logSecondarySpeciesConcentrations[j] );
154154
aggregatePrimarySpeciesConcentrations[i] += params.stoichiometricMatrix( j, i+numSecondarySpecies ) * secondarySpeciesConcentrations_j;
155155
for( int k=0; k<numPrimarySpecies; ++k )
156156
{
157-
REAL_TYPE const dSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentration = logmath::dWrtLogConst() * params.stoichiometricMatrix( j, k+numSecondarySpecies ) * secondarySpeciesConcentrations_j;
157+
REAL_TYPE const dSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentration = logmath::dWrtLogConst<REAL_TYPE>() * params.stoichiometricMatrix( j, k+numSecondarySpecies ) * secondarySpeciesConcentrations_j;
158158
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, k ) += params.stoichiometricMatrix( j, i+numSecondarySpecies ) *
159159
dSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentration;
160160
}
@@ -237,8 +237,8 @@ void calculateTotalAndMobileAggregatePrimaryConcentrationsWrtLogC( PARAMS_DATA c
237237
REAL_TYPE const speciesConcentration_i = logmath::exp( logPrimarySpeciesConcentrations[i] );
238238
aggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i;
239239
mobileAggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i;
240-
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i;
241-
dMobileAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i;
240+
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst<REAL_TYPE>() * speciesConcentration_i;
241+
dMobileAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst<REAL_TYPE>() * speciesConcentration_i;
242242

243243
for( int j = 0; j < numSecondarySpecies; ++j )
244244
{
@@ -247,7 +247,7 @@ void calculateTotalAndMobileAggregatePrimaryConcentrationsWrtLogC( PARAMS_DATA c
247247
mobileAggregatePrimarySpeciesConcentrations[i] += params.stoichiometricMatrix( j, i+numSecondarySpecies ) * secondarySpeciesConcentrations_j * params.mobileSecondarySpeciesFlag( j );
248248
for( int k=0; k<numPrimarySpecies; ++k )
249249
{
250-
REAL_TYPE const dSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentration = logmath::dWrtLogConst() * params.stoichiometricMatrix( j, k+numSecondarySpecies ) * secondarySpeciesConcentrations_j;
250+
REAL_TYPE const dSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentration = logmath::dWrtLogConst<REAL_TYPE>() * params.stoichiometricMatrix( j, k+numSecondarySpecies ) * secondarySpeciesConcentrations_j;
251251
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, k ) += params.stoichiometricMatrix( j, i+numSecondarySpecies ) *
252252
dSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentration;
253253

src/reactions/reactionsSystems/MixedEquilibriumKineticReactions_impl.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ MixedEquilibriumKineticReactions< REAL_TYPE,
7878
REAL_TYPE const speciesConcentration_i = logmath::exp( logPrimarySpeciesConcentrations[i] );
7979
aggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i;
8080
mobileAggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i;
81-
dAggregatePrimarySpeciesConcentrations_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i;
82-
dMobileAggregatePrimarySpeciesConcentrations_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i;
81+
dAggregatePrimarySpeciesConcentrations_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst<REAL_TYPE>() * speciesConcentration_i;
82+
dMobileAggregatePrimarySpeciesConcentrations_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst<REAL_TYPE>() * speciesConcentration_i;
8383
}
8484
}
8585

@@ -168,11 +168,11 @@ MixedEquilibriumKineticReactions< REAL_TYPE,
168168
{
169169
for( IntType j = 0; j < numPrimarySpecies; ++j )
170170
{
171-
dReactionRates_dLogPrimarySpeciesConcentrations( i, j ) = reactionRatesDerivatives( i, j + numSecondarySpecies );
171+
dReactionRates_dLogPrimarySpeciesConcentrations( i, j ) = logmath::dWrtLogConst<REAL_TYPE>() * reactionRatesDerivatives( i, j + numSecondarySpecies );
172172

173173
for( IntType k = 0; k < numSecondarySpecies; ++k )
174174
{
175-
RealType const dLogSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentrations = params.stoichiometricMatrix( k, j + numSecondarySpecies );
175+
RealType const dLogSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentrations = logmath::dWrtLogConst<REAL_TYPE>() * params.stoichiometricMatrix( k, j + numSecondarySpecies );
176176
dReactionRates_dLogPrimarySpeciesConcentrations( i, j ) += reactionRatesDerivatives( i, k ) * dLogSecondarySpeciesConcentrations_dLogPrimarySpeciesConcentrations;
177177
}
178178
}

0 commit comments

Comments
 (0)