Added compilation errors for certain operations on rvalues.

Author: corbett5

src/Array.hpp

@@ -71,11 +71,11 @@ class Array : public ArrayView< T,
   using Permutation = PERMUTATION;
 
   /// Alias for the parent class.
-  using ParentClass = ArrayView< T,
-  NDIM,
-  typeManipulation::getStrideOneDimension( PERMUTATION {} ),
-  INDEX_TYPE,
-  BUFFER_TYPE >;
+  using ParentClass = ArrayView< T, NDIM, typeManipulation::getStrideOneDimension( Permutation {} ), INDEX_TYPE, BUFFER_TYPE >;
+
+  using ParentClass::USD;
+  using typename ParentClass::NestedViewType;
+  using typename ParentClass::NestedViewTypeConst;
 
   /**
    * @name Constructors, destructor and assignment operators.
@@ -186,6 +186,77 @@ class Array : public ArrayView< T,
 
   ///@}
 
+  /**
+   * @name ArrayView and ArraySlice creation methods and user defined conversions.
+   */
+  ///@{
+
+  using ParentClass::toView;
+
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayView.
+   * @note This cannot be called on a rvalue since the @c ArrayView would
+   *   contain the buffer of the current @c Array that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  inline LVARRAY_HOST_DEVICE constexpr
+  ArrayView< T, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > toView() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toView on a rvalue." );
+    return ArrayView< T, NDIM, USD, INDEX_TYPE, BUFFER_TYPE >();
+  }
+
+  using ParentClass::toViewConst;
+
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayView.
+   * @note This cannot be called on a rvalue since the @c ArrayView would
+   *   contain the buffer of the current @c Array that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  inline LVARRAY_HOST_DEVICE constexpr
+  ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > toViewConst() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConst on a rvalue." );
+    return ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE >();
+  }
+
+  using ParentClass::toNestedView;
+
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayView.
+   * @note This cannot be called on a rvalue since the @c ArrayView would
+   *   contain the buffer of the current @c Array that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  inline LVARRAY_HOST_DEVICE constexpr
+  NestedViewType toNestedView() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewNested on a rvalue." );
+    return NestedViewType();
+  }
+
+  using ParentClass::toNestedViewConst;
+
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayView.
+   * @note This cannot be called on a rvalue since the @c ArrayView would
+   *   contain the buffer of the current @c Array that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  inline LVARRAY_HOST_DEVICE constexpr
+  NestedViewTypeConst toNestedViewConst() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewNestedConst on a rvalue." );
+    return NestedViewTypeConst();
+  }
+
+  ///@}
+
   /**
    * @name Resizing methods.
    */

src/ArrayOfArrays.hpp

@@ -52,8 +52,8 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    * @param defaultArrayCapacity the initial capacity of each array.
    */
   inline
-  ArrayOfArrays( INDEX_TYPE const numArrays=0, INDEX_TYPE const defaultArrayCapacity=0 ) LVARRAY_RESTRICT_THIS:
-    ParentClass()
+  ArrayOfArrays( INDEX_TYPE const numArrays=0, INDEX_TYPE const defaultArrayCapacity=0 ):
+    ParentClass( true )
   {
     resize( numArrays, defaultArrayCapacity );
     setName( "" );
@@ -65,7 +65,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    */
   inline
   ArrayOfArrays( ArrayOfArrays const & src ):
-    ParentClass()
+    ParentClass( true )
   { *this = src; }
 
   /**
@@ -95,9 +95,24 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    */
   constexpr inline
   ArrayOfArraysView< T, INDEX_TYPE const, false, BUFFER_TYPE >
-  toView() const LVARRAY_RESTRICT_THIS
+  toView() const &
   { return ParentClass::toView(); }
 
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayOfArraysView.
+   * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
+   *   contain the buffer of the current @c ArrayOfArrays that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  constexpr inline
+  ArrayOfArraysView< T, INDEX_TYPE const, false, BUFFER_TYPE >
+  toView() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toView on a rvalue." );
+    return ParentClass::toView();
+  }
+
   /**
    * @copydoc ParentClass::toViewConstSizes
    * @note This is just a wrapper around the ArrayOfArraysView method. The reason
@@ -106,9 +121,24 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    */
   constexpr inline
   ArrayOfArraysView< T, INDEX_TYPE const, true, BUFFER_TYPE >
-  toViewConstSizes() const LVARRAY_RESTRICT_THIS
+  toViewConstSizes() const &
   { return ParentClass::toViewConstSizes(); }
 
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayOfArraysView.
+   * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
+   *   contain the buffer of the current @c ArrayOfArrays that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  constexpr inline
+  ArrayOfArraysView< T, INDEX_TYPE const, true, BUFFER_TYPE >
+  toViewConstSizes() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConstSizes on a rvalue." );
+    return ParentClass::toViewConstSizes();
+  }
+
   /**
    * @copydoc ParentClass::toViewConst
    * @note This is just a wrapper around the ArrayOfArraysView method. The reason
@@ -117,9 +147,24 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    */
   constexpr inline
   ArrayOfArraysView< T const, INDEX_TYPE const, true, BUFFER_TYPE >
-  toViewConst() const LVARRAY_RESTRICT_THIS
+  toViewConst() const &
   { return ParentClass::toViewConst(); }
 
+  /**
+   * @brief Overload for rvalues that raises a compilation error when used.
+   * @return A null ArrayOfArraysView.
+   * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
+   *   contain the buffer of the current @c ArrayOfArrays that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  constexpr inline
+  ArrayOfArraysView< T const, INDEX_TYPE const, true, BUFFER_TYPE >
+  toViewConst() const &&
+  {
+    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConst on a rvalue." );
+    return ParentClass::toViewConst();
+  }
+
   ///@}
 
   /**
@@ -133,7 +178,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    * @return *this.
    */
   inline
-  ArrayOfArrays & operator=( ArrayOfArrays const & src ) LVARRAY_RESTRICT_THIS
+  ArrayOfArrays & operator=( ArrayOfArrays const & src )
   {
     ParentClass::setEqualTo( src.m_numArrays,
                              src.m_offsets[ src.m_numArrays ],
@@ -183,7 +228,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    *   IS_VALID_EXPRESSION and this fails with NVCC.
    */
   inline
-  INDEX_TYPE size() const LVARRAY_RESTRICT_THIS
+  INDEX_TYPE size() const
   { return ParentClass::size(); }
 
   using ParentClass::sizeOfArray;
@@ -233,7 +278,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    * @brief Append an array.
    * @param n the size of the array.
    */
-  void appendArray( INDEX_TYPE const n ) LVARRAY_RESTRICT_THIS
+  void appendArray( INDEX_TYPE const n )
   {
     LVARRAY_ASSERT( arrayManipulation::isPositive( n ) );
 
@@ -252,7 +297,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    * @param last An iterator to the end of the array to append.
    */
   template< typename ITER >
-  void appendArray( ITER const first, ITER const last ) LVARRAY_RESTRICT_THIS
+  void appendArray( ITER const first, ITER const last )
   {
     INDEX_TYPE const maxOffset = this->m_offsets[ this->m_numArrays ];
     bufferManipulation::emplaceBack( this->m_offsets, this->m_numArrays + 1, maxOffset );
@@ -312,7 +357,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    * @param args A variadic pack of arguments that are forwarded to construct the new value.
    */
   template< typename ... ARGS >
-  void emplaceBack( INDEX_TYPE const i, ARGS && ... args ) LVARRAY_RESTRICT_THIS
+  void emplaceBack( INDEX_TYPE const i, ARGS && ... args )
   {
     dynamicallyGrowArray( i, 1 );
     ParentClass::emplaceBack( i, std::forward< ARGS >( args )... );
@@ -326,7 +371,7 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
    * @param last An iterator to the end of the values to append.
    */
   template< typename ITER >
-  void appendToArray( INDEX_TYPE const i, ITER const first, ITER const last ) LVARRAY_RESTRICT_THIS
+  void appendToArray( INDEX_TYPE const i, ITER const first, ITER const last )
   {
     INDEX_TYPE const n = arrayManipulation::iterDistance( first, last );
     dynamicallyGrowArray( i, n );