Rework of forbidden rvalue methods.

Author: corbett5

RELEASE_NOTES.md

@@ -12,6 +12,7 @@ Version vxx.yy.zz -- Release date 20yy-mm-dd
   * Fixed indexing bug that produced a compilation error with GCC 10.
   * Fixed a memory leak in `CRSMatrix::assimilate`.
   * Fixed a memory leak in `ArrayOfArraysView::free` with non-trivially destructable values.
+  * Fixed a compilation error with GCC 9.
 
 Version v0.1.0 -- Release date 2020-10-13
 =========================================

src/Array.hpp

@@ -194,66 +194,70 @@ class Array : public ArrayView< T,
   using ParentClass::toView;
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
-   * @return A null ArrayView.
+   * @brief Overload for rvalues that is deleted.
+   * @return None.
    * @note This cannot be called on a rvalue since the @c ArrayView would
    *   contain the buffer of the current @c Array that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
-  ArrayView< T, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > toView() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toView on a rvalue." );
-    return ArrayView< T, NDIM, USD, INDEX_TYPE, BUFFER_TYPE >();
-  }
+  ArrayView< T, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > toView() const && = delete;
 
   using ParentClass::toViewConst;
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
-   * @return A null ArrayView.
+   * @brief Overload for rvalues that is deleted.
+   * @return None.
    * @note This cannot be called on a rvalue since the @c ArrayView would
    *   contain the buffer of the current @c Array that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
-  ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > toViewConst() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConst on a rvalue." );
-    return ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE >();
-  }
+  ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > toViewConst() const && = delete;
 
   using ParentClass::toNestedView;
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
-   * @return A null ArrayView.
+   * @brief Overload for rvalues that is deleted.
+   * @return None.
    * @note This cannot be called on a rvalue since the @c ArrayView would
    *   contain the buffer of the current @c Array that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
-  NestedViewType toNestedView() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewNested on a rvalue." );
-    return NestedViewType();
-  }
+  NestedViewType toNestedView() const && = delete;
 
   using ParentClass::toNestedViewConst;
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
-   * @return A null ArrayView.
+   * @brief Overload for rvalues that is deleted.
+   * @return None.
    * @note This cannot be called on a rvalue since the @c ArrayView would
    *   contain the buffer of the current @c Array that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
-  NestedViewTypeConst toNestedViewConst() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewNestedConst on a rvalue." );
-    return NestedViewTypeConst();
-  }
+  NestedViewTypeConst toNestedViewConst() const && = delete;
+
+  /**
+   * @brief A user defined conversion operator (UDC) to an ArrayView< T const, ... >.
+   * @return A new ArrayView where @c T is @c const.
+   */
+  inline LVARRAY_HOST_DEVICE constexpr
+  operator ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE >() const & noexcept
+  { return toViewConst(); }
+
+  /**
+   * @brief Overload for rvalues that is deleted.
+   * @return None.
+   * @note This cannot be called on a rvalue since the @c ArrayView would
+   *   contain the buffer of the current @c Array that is about to be destroyed.
+   *   This overload prevents that from happening.
+   */
+  template< typename _T=T >
+  inline LVARRAY_HOST_DEVICE constexpr
+  operator std::enable_if_t< !std::is_const< _T >::value,
+                             ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > >() const && noexcept = delete;
 
   ///@}
 

src/ArrayOfArrays.hpp

@@ -99,19 +99,15 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
   { return ParentClass::toView(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArrayOfArraysView.
    * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
    *   contain the buffer of the current @c ArrayOfArrays that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   constexpr inline
   ArrayOfArraysView< T, INDEX_TYPE const, false, BUFFER_TYPE >
-  toView() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toView on a rvalue." );
-    return ParentClass::toView();
-  }
+  toView() const && = delete;
 
   /**
    * @copydoc ParentClass::toViewConstSizes
@@ -125,19 +121,15 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
   { return ParentClass::toViewConstSizes(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArrayOfArraysView.
    * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
    *   contain the buffer of the current @c ArrayOfArrays that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   constexpr inline
   ArrayOfArraysView< T, INDEX_TYPE const, true, BUFFER_TYPE >
-  toViewConstSizes() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConstSizes on a rvalue." );
-    return ParentClass::toViewConstSizes();
-  }
+  toViewConstSizes() const && = delete;
 
   /**
    * @copydoc ParentClass::toViewConst
@@ -151,19 +143,15 @@ class ArrayOfArrays : protected ArrayOfArraysView< T, INDEX_TYPE, false, BUFFER_
   { return ParentClass::toViewConst(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArrayOfArraysView.
    * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
    *   contain the buffer of the current @c ArrayOfArrays that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   constexpr inline
   ArrayOfArraysView< T const, INDEX_TYPE const, true, BUFFER_TYPE >
-  toViewConst() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConst on a rvalue." );
-    return ParentClass::toViewConst();
-  }
+  toViewConst() const && = delete;
 
   ///@}
 

src/ArrayOfSets.hpp

@@ -193,19 +193,15 @@ class ArrayOfSets : protected ArrayOfSetsView< T, INDEX_TYPE, BUFFER_TYPE >
   { return ParentClass::toView(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArrayOfSetsView.
    * @note This cannot be called on a rvalue since the @c ArrayOfSetsView would
    *   contain the buffers of the current @c ArrayOfSets that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   constexpr inline
   ArrayOfSetsView< T, INDEX_TYPE const, BUFFER_TYPE >
-  toView() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toView on a rvalue." );
-    return ParentClass::toView();
-  }
+  toView() const && = delete;
 
   /**
    * @copydoc ParentClass::toViewConst
@@ -219,19 +215,15 @@ class ArrayOfSets : protected ArrayOfSetsView< T, INDEX_TYPE, BUFFER_TYPE >
   { return ParentClass::toViewConst(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArrayOfSetsView.
    * @note This cannot be called on a rvalue since the @c ArrayOfSetsView would
    *   contain the buffers of the current @c ArrayOfSets that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   constexpr inline
   ArrayOfSetsView< T const, INDEX_TYPE const, BUFFER_TYPE >
-  toViewConst() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toViewConst on a rvalue." );
-    return ParentClass::toViewConst();
-  }
+  toViewConst() const && = delete;
 
   /**
    * @copydoc ParentClass::toArrayOfArraysView
@@ -245,19 +237,15 @@ class ArrayOfSets : protected ArrayOfSetsView< T, INDEX_TYPE, BUFFER_TYPE >
   { return ParentClass::toArrayOfArraysView(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArrayOfSetsView.
    * @note This cannot be called on a rvalue since the @c ArrayOfArraysView would
    *   contain the buffers of the current @c ArrayOfSets that is about to be destroyed.
    *   This overload prevents that from happening.
    */
   constexpr inline
   ArrayOfArraysView< T const, INDEX_TYPE const, true, BUFFER_TYPE >
-  toArrayOfArraysView() const &&
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toArrayOfArraysView on a rvalue." );
-    return ParentClass::toArrayOfArraysView();
-  }
+  toArrayOfArraysView() const && = delete;
 
   ///@}
 

src/ArrayView.hpp

@@ -270,19 +270,15 @@ class ArrayView
   { return ArraySlice< T, NDIM, USD, INDEX_TYPE >( data(), m_dims.data, m_strides.data ); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArraySlice.
    * @note This cannot be called on a rvalue since the @c ArraySlice would
    *   contain pointers to the dims and strides of the current @c ArrayView that is
    *   about to be destroyed. This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
   ArraySlice< T, NDIM, USD, INDEX_TYPE >
-  toSlice() const && noexcept
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toSlice on a rvalue." );
-    return ArraySlice< T, NDIM, USD, INDEX_TYPE >( nullptr, nullptr, nullptr );
-  }
+  toSlice() const && noexcept = delete;
 
   /**
    * @return Return an immutable ArraySlice representing this ArrayView.
@@ -293,19 +289,15 @@ class ArrayView
   { return ArraySlice< T const, NDIM, USD, INDEX_TYPE >( data(), m_dims.data, m_strides.data ); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArraySlice.
    * @brief This cannot be called on a rvalue since the @c ArraySlice would
    *   contain pointers to the dims and strides of the current @c ArrayView that is
    *   about to be destroyed. This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
   ArraySlice< T const, NDIM, USD, INDEX_TYPE >
-  toSliceConst() const && noexcept
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot call toSliceConst on a rvalue." );
-    return ArraySlice< T const, NDIM, USD, INDEX_TYPE >( nullptr, nullptr, nullptr );
-  }
+  toSliceConst() const && noexcept = delete;
 
   /**
    * @brief A user defined conversion operator (UDC) to an ArrayView< T const, ... >.
@@ -314,26 +306,9 @@ class ArrayView
   template< typename _T=T >
   inline LVARRAY_HOST_DEVICE constexpr
   operator std::enable_if_t< !std::is_const< _T >::value,
-                             ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > >() const & noexcept
+                             ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > >() const noexcept
   { return toViewConst(); }
 
-  /**
-   * @brief Overload for rvalues that raises a compilation error when used.
-   * @return A null ArrayView.
-   * @brief This is valid when this is an @c ArrayView but invalid when this is an @c Array.
-   *   I have been unable to allow the @c ArrayView conversion while not allowing the @c Array.
-   *   Therefore the @c ArrayView conversion is not allowed, instead simply call @c toViewConst.
-   */
-  template< typename _T=T >
-  inline LVARRAY_HOST_DEVICE constexpr
-  operator std::enable_if_t< !std::is_const< _T >::value,
-                             ArrayView< T const, NDIM, USD, INDEX_TYPE, BUFFER_TYPE > >() const && noexcept
-  {
-    static_assert( !typeManipulation::always_true< T >,
-                   "Cannot call toViewConst on a rvalue. If called from ArrayView please use toViewConst()." );
-    return toViewConst();
-  }
-
   /**
    * @return Return an ArraySlice representing this ArrayView.
    */
@@ -342,18 +317,14 @@ class ArrayView
   { return toSlice(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArraySlice.
    * @brief This conversion cannot be called on a rvalue since the @c ArraySlice would
    *   contain pointers to the dims and strides of the current @c ArrayView that is
    *   about to be destroyed. This overload prevents that from happening.
    */
   inline LVARRAY_HOST_DEVICE constexpr
-  operator ArraySlice< T, NDIM, USD, INDEX_TYPE >() const && noexcept
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot use conversion to an ArraySlice< T, ... > on a rvalue." );
-    return ArraySlice< T, NDIM, USD, INDEX_TYPE >( nullptr, nullptr, nullptr );
-  }
+  operator ArraySlice< T, NDIM, USD, INDEX_TYPE >() const && noexcept = delete;
 
   /**
    * @return Return an immutable ArraySlice representing this ArrayView.
@@ -365,7 +336,7 @@ class ArrayView
   { return toSliceConst(); }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @return A null ArraySlice.
    * @brief This conversion cannot be called on a rvalue since the @c ArraySlice would
    *   contain pointers to the dims and strides of the current @c ArrayView that is
@@ -374,11 +345,7 @@ class ArrayView
   template< typename _T=T >
   inline LVARRAY_HOST_DEVICE constexpr
   operator std::enable_if_t< !std::is_const< _T >::value,
-                             ArraySlice< T const, NDIM, USD, INDEX_TYPE > const >() const && noexcept
-  {
-    static_assert( !typeManipulation::always_true< T >, "Cannot use conversion to an ArraySlice< T const, ... > on a rvalue." );
-    return ArraySlice< T const, NDIM, USD, INDEX_TYPE >( nullptr, nullptr, nullptr );
-  }
+                             ArraySlice< T const, NDIM, USD, INDEX_TYPE > const >() const && noexcept = delete;
 
   ///@}
 
@@ -495,7 +462,7 @@ class ArrayView
   }
 
   /**
-   * @brief Overload for rvalues that raises a compilation error when used.
+   * @brief Overload for rvalues that is deleted.
    * @param index Not used.
    * @return A null ArraySlice.
    * @brief The multidimensional operator[] cannot be called on a rvalue since the @c ArraySlice
@@ -505,12 +472,7 @@ class ArrayView
   template< int _NDIM=NDIM >
   LVARRAY_HOST_DEVICE inline CONSTEXPR_WITHOUT_BOUNDS_CHECK
   std::enable_if_t< (_NDIM > 1), ArraySlice< T, NDIM - 1, USD - 1, INDEX_TYPE > >
-  operator[]( INDEX_TYPE const index ) const && noexcept
-  {
-    LVARRAY_UNUSED_VARIABLE( index );
-    static_assert( !typeManipulation::always_true< T >, "Cannot call multidimensional operator[] on an rvalue." );
-    return ArraySlice< T, NDIM-1, USD-1, INDEX_TYPE >( nullptr, nullptr, nullptr );
-  }
+  operator[]( INDEX_TYPE const index ) const && noexcept = delete;
 
   /**
    * @return Return a reference to the value at the given index.