Fixed GCC warning in release.

corbett5 · corbett5 · commit 9e778b0325cf · 2021-09-09T16:13:15.000-07:00
diff --git a/src/arrayManipulation.hpp b/src/arrayManipulation.hpp
@@ -296,12 +296,13 @@ void resize( T * const LVARRAY_RESTRICT ptr,
   {
     if( newSize - size > 0 )
     {
-      memset( reinterpret_cast< void * >( ptr + size ), 0, ( newSize - size ) * sizeof( T ) );
+      std::memset( reinterpret_cast< void * >( ptr + size ), 0, ( newSize - size ) * sizeof( T ) );
     }
   }
   else
   {
-    for( std::ptrdiff_t i = size; i < newSize; ++i )
+    // Use std::size_t so that when GCC optimizes this it doesn't produce sign warnings.
+    for( std::size_t i = size; i < std::size_t( newSize ); ++i )
     {
       new ( ptr + i ) T( std::forward< ARGS >( args )... );
     }

Original file line number	Diff line number	Diff line change
`@@ -296,12 +296,13 @@ void resize( T * const LVARRAY_RESTRICT ptr,`
`296`	`296`	`{`
`297`	`297`	`if( newSize - size > 0 )`
`298`	`298`	`{`
`299`		`- memset( reinterpret_cast< void * >( ptr + size ), 0, ( newSize - size ) * sizeof( T ) );`
	`299`	`+ std::memset( reinterpret_cast< void * >( ptr + size ), 0, ( newSize - size ) * sizeof( T ) );`
`300`	`300`	`}`
`301`	`301`	`}`
`302`	`302`	`else`
`303`	`303`	`{`
`304`		`- for( std::ptrdiff_t i = size; i < newSize; ++i )`
	`304`	`+ // Use std::size_t so that when GCC optimizes this it doesn't produce sign warnings.`
	`305`	`+ for( std::size_t i = size; i < std::size_t( newSize ); ++i )`
`305`	`306`	`{`
`306`	`307`	`new ( ptr + i ) T( std::forward< ARGS >( args )... );`
`307`	`308`	`}`