clang 10.0.1 changes.

Author: corbett5

src/sortedArrayManipulation.hpp

@@ -315,20 +315,17 @@ std::ptrdiff_t removeDuplicates( ITER first, ITER const last, Compare && comp=Co
 
   std::ptrdiff_t numUnique = 1;
 
-  ITER next = first;
-
   /**
-   * For whatever reason the standard approach doesn't work with XL in release on device.
+   * The following statement should be
+   *   ITER next = first;
+   *   ++next;
+   * This works host only however with some host compilers (clang 10.0.1 and XL) it breaks on device in release.
    * It does some really strange things, for example `last - next == 0` and they can have identical
-   * values but `next != last`. If you print out the array each iteration it works as expected. I even
-   * tried substituting the example code for std::unique from cppreference and that exhibited the same problem.
-   * My guess is it's most likely a compiler bug.
+   * values but `next != last`. If you print out the array each iteration it works as expected. It's not a big deal
+   * since it amounts to just a single extra iteration, but very strange.
    */
-#if defined( __ibmxl__ ) && defined( __CUDA_ARCH__ )
-  while( arrayManipulation::iterDistance( ++next, last ) > 0 )
-#else
-  while( ++next != last )
-#endif
+  ITER next = first;
+  for(; next != last; ++next )
   {
     if( comp( *first, *next ) )
     {

unitTests/testSortedArrayManipulation.cpp

@@ -181,9 +181,9 @@ class SingleArrayTest : public ::testing::Test
 using SingleArrayTestTypes = ::testing::Types<
   std::tuple< int, sortedArrayManipulation::less< int >, serialPolicy >
   , std::tuple< int, sortedArrayManipulation::greater< int >, serialPolicy >
+  , std::tuple< Tensor, sortedArrayManipulation::less< Tensor >, serialPolicy >
   , std::tuple< Tensor, sortedArrayManipulation::greater< Tensor >, serialPolicy >
-  , std::tuple< Tensor, sortedArrayManipulation::greater< Tensor >, serialPolicy >
-  , std::tuple< TestString, sortedArrayManipulation::greater< TestString >, serialPolicy >
+  , std::tuple< TestString, sortedArrayManipulation::less< TestString >, serialPolicy >
   , std::tuple< TestString, sortedArrayManipulation::greater< TestString >, serialPolicy >
 
 #if defined(LVARRAY_USE_CUDA) && defined(LVARRAY_USE_CHAI)
@@ -304,3 +304,11 @@ TYPED_TEST( DualArrayTest, makeSorted )
 
 } // namespace testing
 } // namespace LvArray
+
+// This is the default gtest main method. It is included for ease of debugging.
+int main( int argc, char * * argv )
+{
+  ::testing::InitGoogleTest( &argc, argv );
+  int const result = RUN_ALL_TESTS();
+  return result;
+}

unitTests/testTensorOpsOneSize.cpp

@@ -372,8 +372,7 @@ class OneSizeTest : public ::testing::Test
     T const ( &vectorB_local )[ N ] = m_vectorB_local;
 
     std::ptrdiff_t const aSeed = m_seedVectorA;
-    T const epsilon = NumericLimitsNC< T >{}.epsilon;
-    forall< POLICY >( 1, [vectorA_IJ, vectorA_JI, vectorB_IJ, vectorB_JI, vectorB_local, aSeed, epsilon] LVARRAY_HOST_DEVICE ( int )
+    forall< POLICY >( 1, [vectorA_IJ, vectorA_JI, vectorB_IJ, vectorB_JI, vectorB_local, aSeed] LVARRAY_HOST_DEVICE ( int )
         {
           #define _TEST( a, b ) \
             tensorOps::scaledAdd< N >( a, b, scale ); \
@@ -385,6 +384,8 @@ class OneSizeTest : public ::testing::Test
             _TEST( a, b1 ); \
             _TEST( a, b2 )
 
+          T const epsilon = NumericLimitsNC< T >{}.epsilon;
+
           T vectorA_local[ N ];
           fill( vectorA_local, aSeed );