Skip to content

SRF_TYPE Bug in Moist Process_Library #1122

@mathomp4

Description

@mathomp4

A possible/probable bug was found by @gmao-rreichle in this chunk of code which is essentially:

      if (SRF_TYPE >= 2.0) then
        ! Over snow (SRF_TYPE == 2.0) and ice (SRF_TYPE == 3.0)
		do stuff
      else if (SRF_TYPE > 1.0) then
        ! Over Land
		do stuff
      else
        ! Over Oceans
		do stuff
      endif

where SRF_TYPE = 1 is land. But as @gmao-rreichle noticed, the first if is good for SRF_TYPE 2 and 3, but the second one will never execute for SRF_TYPE==1.0. Now, for some floating point weirdness, maybe it will (for 1.000001) but it should be SRF_TYPE >= 1.0 it seems.

I'm going to code up a couple quick fix branches for this for testing.

cc: @sdrabenh @wmputman @narnold1

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions