Skip to content

Commit 4bce232

Browse files
fix bug in ASCAT_EUMET soil moisture obs reader #148
Before this bug fix, after reading the obs from the files that overlap with the assimilation window, the obs were not properly screened for falling into the assimilation window. This resulted in ~40% of the observations being assimilation twice.
2 parents 754e2eb + 4f0396a commit 4bce232

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2222

2323
### Fixed
2424

25+
- Fixed bug in ASCAT EUMET soil moisture obs reader.
2526
- Fixed Restart=1 when the domain is not global.
2627

2728
### Removed

GEOSlandassim_GridComp/clsm_ensupd_read_obs.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1951,8 +1951,8 @@ subroutine read_obs_sm_ASCAT_EUMET( &
19511951
date_time_tmp%sec = int(tmp_data(kk, 6))
19521952

19531953
! skip if record outside of current assim window
1954-
if ( datetime_lt_refdatetime( date_time_tmp, date_time_low ) .and. &
1955-
datetime_le_refdatetime( date_time_up, date_time_tmp ) ) cycle
1954+
if ( datetime_lt_refdatetime( date_time_tmp, date_time_low ) .or. & ! obs is before start of assim window *or*
1955+
datetime_le_refdatetime( date_time_up, date_time_tmp ) ) cycle ! obs is after end of assim window
19561956

19571957
! skip if record contains invalid soil moisture value
19581958
if ( tmp_data(kk, 7) > 100. .or. tmp_data(kk, 7) < 0. ) cycle

0 commit comments

Comments
 (0)