Skip to content

Commit 90e6637

Browse files
authored
rocketchat notifications workflow fixes (#120)
* drop useless notification: code review on issues 🤦 * fix links to issues
1 parent 7a1a7af commit 90e6637

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

.github/workflows/rocketchat-notifications-feedback-requests.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,11 @@ jobs:
2525
rocketchat_issue_notification:
2626
name: Someone labeled their Issue
2727
runs-on: ubuntu-latest
28-
if: ${{ github.event.issue && contains('comments welcome|help wanted|waiting for review', github.event.label.name) }}
28+
if: ${{ github.event.issue && contains('comments welcome|help wanted', github.event.label.name) }}
2929
steps:
3030
- name: Push notification for an Issue labeled as "comments welcome"
3131
if: ${{ github.event.label.name == 'comments welcome' }}
32-
run: curl "${{ secrets.ROCKETCHAT_SERVER }}/hooks/${{ secrets.ROCKETCHAT_HOOK_PR_NOTIFICATIONS }}" -d "text=${{ github.event.sender.login }} would like to get feedback on issue ${{ github.event.pull_request.html_url }}" -d "username=${{ github.event.sender.login }}" -d "avatar=${{ github.event.sender.avatar_url }}"
32+
run: curl "${{ secrets.ROCKETCHAT_SERVER }}/hooks/${{ secrets.ROCKETCHAT_HOOK_PR_NOTIFICATIONS }}" -d "text=${{ github.event.sender.login }} would like to get feedback on issue ${{ github.event.issue.html_url }}" -d "username=${{ github.event.sender.login }}" -d "avatar=${{ github.event.sender.avatar_url }}"
3333
- name: Push notification for an Issue labeled as "help wanted"
3434
if: ${{ github.event.label.name == 'help wanted' }}
35-
run: curl "${{ secrets.ROCKETCHAT_SERVER }}/hooks/${{ secrets.ROCKETCHAT_HOOK_PR_NOTIFICATIONS }}" -d "text=${{ github.event.sender.login }} needs help with issue ${{ github.event.pull_request.html_url }}" -d "username=${{ github.event.sender.login }}" -d "avatar=${{ github.event.sender.avatar_url }}"
36-
- name: Push notification for an Issue labeled as "waiting for review"
37-
if: ${{ github.event.label.name == 'waiting for review' }}
38-
run: curl "${{ secrets.ROCKETCHAT_SERVER }}/hooks/${{ secrets.ROCKETCHAT_HOOK_PR_NOTIFICATIONS }}" -d "text=${{ github.event.sender.login }} is waiting for a code review of issue ${{ github.event.pull_request.html_url }}" -d "username=${{ github.event.sender.login }}" -d "avatar=${{ github.event.sender.avatar_url }}"
35+
run: curl "${{ secrets.ROCKETCHAT_SERVER }}/hooks/${{ secrets.ROCKETCHAT_HOOK_PR_NOTIFICATIONS }}" -d "text=${{ github.event.sender.login }} needs help with issue ${{ github.event.issue.html_url }}" -d "username=${{ github.event.sender.login }}" -d "avatar=${{ github.event.sender.avatar_url }}"

0 commit comments

Comments
 (0)