Skip to content

Commit 1935fa5

Browse files
author
nilsnolde
committed
fix previous commit and delete right test
1 parent 920c092 commit 1935fa5

File tree

1 file changed

+35
-37
lines changed

1 file changed

+35
-37
lines changed

test/test_client.py

Lines changed: 35 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -46,47 +46,45 @@ def test_invalid_api_key(self):
4646
def test_urlencode(self):
4747
encoded_params = openrouteservice.client._urlencode_params([("address", "=Sydney ~")])
4848
self.assertEqual("address=%3DSydney+~", encoded_params)
49-
50-
# Reactivate this test when secret env variable is set up in Travis
51-
52-
# @responses.activate
53-
# def test_queries_per_minute_sleep_function(self):
54-
# # This test assumes that the time to run a mocked query is
55-
# # relatively small, eg a few milliseconds. We define a rate of
56-
# # 3 queries per second, and run double that, which should take at
57-
# # least 1 minute but no more than 2.
58-
# queries_per_minute = 2
59-
# query_range = range(queries_per_minute * 2)
60-
#
61-
# for _ in query_range:
62-
# responses.add(responses.GET,
63-
# 'https://api.openrouteservice.org/directions',
64-
# body='{"status":"OK","results":[]}',
65-
# status=200,
66-
# content_type='application/json')
67-
#
68-
# client = openrouteservice.Client(key="58d904a497c67e00015b45fcc8de25513ac6446692280cb066e66e8c",
69-
# queries_per_minute=queries_per_minute)
70-
# start = time.time()
71-
# for idx, _ in enumerate(query_range):
72-
# client.directions(self.coords_valid)
73-
# end = time.time()
74-
# self.assertTrue(start + 60 < end < start + 120)
7549

76-
def test_overquerylimit_error(self):
77-
# Assume more queries_per_minute than allowed by API policy and
78-
# don't allow retries if API throws 'rate exceeded' error, which
79-
# should be caught.
80-
queries_per_minute = 110
50+
@responses.activate
51+
def test_queries_per_minute_sleep_function(self):
52+
# This test assumes that the time to run a mocked query is
53+
# relatively small, eg a few milliseconds. We define a rate of
54+
# 3 queries per second, and run double that, which should take at
55+
# least 1 minute but no more than 2.
56+
queries_per_minute = 2
8157
query_range = range(queries_per_minute * 2)
58+
59+
for _ in query_range:
60+
responses.add(responses.GET,
61+
'https://api.openrouteservice.org/directions',
62+
body='{"status":"OK","results":[]}',
63+
status=200,
64+
content_type='application/json')
8265

83-
client = openrouteservice.Client(key='5b3ce3597851110001cf624870cf2f2a58d44c718542b3088221b684',
84-
queries_per_minute=queries_per_minute,
85-
retry_over_query_limit=False)
66+
client = openrouteservice.Client(key=self.key,
67+
queries_per_minute=queries_per_minute)
68+
start = time.time()
69+
for idx, _ in enumerate(query_range):
70+
client.directions(self.coords_valid)
71+
end = time.time()
72+
self.assertTrue(start + 60 < end < start + 120)
8673

87-
with self.assertRaises(openrouteservice.exceptions._OverQueryLimit):
88-
for _ in query_range:
89-
client.directions(self.coords_valid)
74+
# def test_overquerylimit_error(self):
75+
# # Assume more queries_per_minute than allowed by API policy and
76+
# # don't allow retries if API throws 'rate exceeded' error, which
77+
# # should be caught.
78+
# queries_per_minute = 110
79+
# query_range = range(queries_per_minute * 2)
80+
#
81+
# client = openrouteservice.Client(key='5b3ce3597851110001cf624870cf2f2a58d44c718542b3088221b684',
82+
# queries_per_minute=queries_per_minute,
83+
# retry_over_query_limit=False)
84+
#
85+
# with self.assertRaises(openrouteservice.exceptions._OverQueryLimit):
86+
# for _ in query_range:
87+
# client.directions(self.coords_valid)
9088

9189
@responses.activate
9290
def test_raise_timeout_retriable_requests(self):

0 commit comments

Comments
 (0)