Merge pull request #45 from GIScience/get-params-fix

get_params is now ignored if not set

Author: nilsnolde

openrouteservice/client.py

@@ -263,6 +263,8 @@ def _generate_auth_url(path, params):
 
         if type(params) is dict:
             params = sorted(dict(**params).items())
+        elif params is None:
+            return path
 
         return path + "?" + _urlencode_params(params)
 

test/test_client.py

@@ -114,6 +114,23 @@ def test_dry_run(self):
 
         self.assertEqual(0, len(responses.calls))
 
+    @responses.activate
+    def test_no_get_parameter(self):
+
+        responses.add(responses.POST,
+                      'https://api.openrouteservice.org/directions',
+                      body='{"status":"OK","results":[]}',
+                      status=200,
+                      content_type='application/json')
+
+        req = self.client.request(post_json={},
+                                  url='v2/directions/driving-car/json',
+                                  dry_run='true')
+
+        self.assertEqual(0, len(responses.calls))
+
+    # Test if the client works with a post request without a get parameter
+
     @responses.activate
     def test_key_in_header(self):
         # Test that API key is being put in the Authorization header