fix: tweak road bike flag encoder in order to restore its desired behavior

Author: aoles

ors-engine/src/main/java/org/heigit/ors/routing/graphhopper/extensions/flagencoders/bike/RoadBikeFlagEncoder.java

@@ -89,16 +89,17 @@ public RoadBikeFlagEncoder(int speedBits, double speedFactor, int maxTurnCosts,
         setTrackTypeSpeed("grade4", PUSHING_SECTION_SPEED);
         setTrackTypeSpeed("grade5", PUSHING_SECTION_SPEED);
 
-        setSurfaceSpeed("paved", 26, UpdateType.DOWNGRADE_ONLY);
-        setSurfaceSpeed("asphalt", 26, UpdateType.DOWNGRADE_ONLY);
+        setSurfaceSpeed("paved", 20, UpdateType.UPGRADE_ONLY);
+        setSurfaceSpeed("asphalt", 20, UpdateType.UPGRADE_ONLY);
+        setSurfaceSpeed("concrete", 20, UpdateType.UPGRADE_ONLY);
+
         setSurfaceSpeed("cobblestone", 10, UpdateType.DOWNGRADE_ONLY);
         setSurfaceSpeed("cobblestone:flattened", 10, UpdateType.DOWNGRADE_ONLY);
         setSurfaceSpeed("sett", 10, UpdateType.DOWNGRADE_ONLY);
-        setSurfaceSpeed("concrete", 26, UpdateType.DOWNGRADE_ONLY);
         setSurfaceSpeed("concrete:lanes", 16, UpdateType.DOWNGRADE_ONLY);
         setSurfaceSpeed("concrete:plates", 16, UpdateType.DOWNGRADE_ONLY);
-        setSurfaceSpeed("paving_stones", 10, UpdateType.DOWNGRADE_ONLY);
-        setSurfaceSpeed("paving_stones:30", 10, UpdateType.DOWNGRADE_ONLY);
+        setSurfaceSpeed("paving_stones", 12, UpdateType.DOWNGRADE_ONLY);
+        setSurfaceSpeed("paving_stones:30", 12, UpdateType.DOWNGRADE_ONLY);
         setSurfaceSpeed("unpaved", PUSHING_SECTION_SPEED / 2);
         setSurfaceSpeed("compacted", PUSHING_SECTION_SPEED / 2);
         setSurfaceSpeed("dirt", PUSHING_SECTION_SPEED / 2);
@@ -116,7 +117,7 @@ public RoadBikeFlagEncoder(int speedBits, double speedFactor, int maxTurnCosts,
         setSurfaceSpeed("sand", PUSHING_SECTION_SPEED / 2);
         setSurfaceSpeed("wood", PUSHING_SECTION_SPEED / 2);
 
-        setHighwaySpeed(KEY_CYCLEWAY, 18);
+        setHighwaySpeed(KEY_CYCLEWAY, new SpeedValue(18, UpdateType.DOWNGRADE_ONLY));
         setHighwaySpeed("living_street", 10);
         setHighwaySpeed("path", 8);
         setHighwaySpeed("footway", 6);
@@ -125,7 +126,7 @@ public RoadBikeFlagEncoder(int speedBits, double speedFactor, int maxTurnCosts,
         setHighwaySpeed(VAL_TRACK, PUSHING_SECTION_SPEED / 2); // assume unpaved
         setHighwaySpeed(VAL_SERVICE, 12);
         setHighwaySpeed(VAL_UNCLASSIFIED, 20);
-        setHighwaySpeed(VAL_RESIDENTIAL, 18);
+        setHighwaySpeed(VAL_RESIDENTIAL, new SpeedValue(18, UpdateType.DOWNGRADE_ONLY));
 
         setHighwaySpeed("trunk", 20);
         setHighwaySpeed("trunk_link", 20);
@@ -142,8 +143,6 @@ public RoadBikeFlagEncoder(int speedBits, double speedFactor, int maxTurnCosts,
         addPushingSection("steps");
         addPushingSection(KEY_BRIDLEWAY);
 
-        routeMap.put(LOCAL, UNCHANGED.getValue());
-
         blockByDefaultBarriers.add("kissing_gate");
 
         setAvoidSpeedLimit(81);